Repository navigation
The train boards a deploy fix first, and quotes the lines that refused - #184
Merged
Merged
Conversation
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Asa3LuNYtPDBa4FbSEQUZ
Contributor
|
Merge train notice: the merge train merges this pull request once it is green on current main; don't enable auto-merge. Generated by Claude Code |
Contributor
|
Live: this change is on the published page, as main The publish job opened the published page in a fresh Chromium and its live checks passed (PG-01, PD-01, PD-02): https://github.com/afflom/me/actions/runs/43977249372 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The first run of the new train (43941997672, the workflow from #182) did what it was written to do: #175, #181 and #183 boarded together, the gates refused the tree, and one by one it accepted #175 and #183 and refused #181. Two things it showed:
What changes
In the model
app/specs/pipeline/workflows/merge-train.yml.json, rendered again to.github/workflows/merge-train.yml:deploy-blocked(the labeldeploy-watch.ymlgives the issue it opens when the live page falls behind main) boards before the others. Among themselves each group keeps number order. Nothing else about readiness changes: it still has to be green, and it still has to pass the gates on the tree it merges in.Checks
#1760does not match issue 176, and an empty ready list stays empty.bash -non both jobs' scripts of the rendered workflow;tools/generators/run.sh --check(GN-01).Not run: either change on a runner. The first train run after this merges is the test, and I will read it.
Generated by Claude Code