Repository navigation
The train runs all its gates once per batch and says what refused - #182
Merged
Merged
Conversation
… and says what refused Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Asa3LuNYtPDBa4FbSEQUZ
Contributor
|
Merge train notice: the merge train merges this pull request once it is green on current main; don't enable auto-merge. Generated by Claude Code |
Contributor
|
Live: this change is on the published page, as main The publish job opened the published page in a fresh Chromium and its live checks passed (PG-01, PD-01, PD-02): https://github.com/afflom/me/actions/runs/43977249372 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The first batch-mode train run on a runner (43893512223) accepted #162, #172 and #179 together and took 80 minutes: the browser acceptances ran once, but the fast gates still ran once per pull request. And when the train refuses a pull request, its comment says only "the fast gates or the browser acceptances refuse it; see run N", while the run's log keeps the last 40 lines of the gates' output, where the failing test's name usually is not.
What changes
In the model
app/specs/pipeline/workflows/merge-train.yml.json, rendered again to.github/workflows/merge-train.yml:not oklines,gate failedlines and gate lines such asHW-01: …(up to eight, at most 900 characters, with@and backticks removed), prints them in the run's log, and puts them in the pull request's refusal comment after "They say:".Checks
not okline in the reason; a batch of one bad pull request is refused after one gate run; a batch of two good ones is accepted after one gate run.bash -non both jobs' scripts of the rendered workflow;tools/generators/run.sh --check(GN-01).Not run: the new loop on a runner. The train that merges this pull request still runs the old workflow; the first run after it merges is the first real one, and I will read it.
Generated by Claude Code