Skip to content

The train runs all its gates once per batch and says what refused - #182

Merged
github-actions[bot] merged 1 commit into
mainfrom
claude/project-thread-jbqzew
Nov 16, 2026
Merged

github-actions[bot] merged 1 commit into
mainfrom
claude/project-thread-jbqzew

Conversation

@afflom

@afflom afflom commented Nov 16, 2026

Copy link
Copy Markdown
Owner

Why

The first batch-mode train run on a runner (43893512223) accepted #162, #172 and #179 together and took 80 minutes: the browser acceptances ran once, but the fast gates still ran once per pull request. And when the train refuses a pull request, its comment says only "the fast gates or the browser acceptances refuse it; see run N", while the run's log keeps the last 40 lines of the gates' output, where the failing test's name usually is not.

What changes

In the model app/specs/pipeline/workflows/merge-train.yml.json, rendered again to .github/workflows/merge-train.yml:

  • All gates once per batch. Every ready pull request that merges cleanly boards onto main in order; then the fast gates and the browser acceptances run once on that tree. If they pass, all are accepted. Only if they fail does the train go back to main and take them one by one, each through all the gates, to find which it refuses. What is tested is still exactly the tree that merges.
  • A batch of one that fails is refused at once, without running the same gates on the same tree a second time.
  • The refusal says what refused. From the gates' log the train takes the not ok lines, gate failed lines and gate lines such as HW-01: … (up to eight, at most 900 characters, with @ and backticks removed), prints them in the run's log, and puts them in the pull request's refusal comment after "They say:".

Checks

  • The new loop run in a scratch repository with stubbed gates: four pull requests board, the tree fails, the one-by-one pass accepts three and refuses the planted bad one with its not ok line in the reason; a batch of one bad pull request is refused after one gate run; a batch of two good ones is accepted after one gate run.
  • bash -n on both jobs' scripts of the rendered workflow; tools/generators/run.sh --check (GN-01).

Not run: the new loop on a runner. The train that merges this pull request still runs the old workflow; the first run after it merges is the first real one, and I will read it.


Generated by Claude Code

… and says what refused

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013Asa3LuNYtPDBa4FbSEQUZ
@github-actions

Copy link
Copy Markdown
Contributor

Merge train notice: the merge train merges this pull request once it is green on current main; don't enable auto-merge.


Generated by Claude Code

@github-actions
github-actions Bot merged commit cfd9a71 into main Nov 16, 2026
7 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Live: this change is on the published page, as main fe7ec040132bcad07dcfafb0fa4dc2b07cd86c78.

The publish job opened the published page in a fresh Chromium and its live checks passed (PG-01, PD-01, PD-02): https://github.com/afflom/me/actions/runs/43977249372

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants