Repository navigation
Use Company-driven Poppy 0.3 approvals and preserve checkout links - #38
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Send Poppy 0.3 task requests before Company confirmation, retain their durable identity through replay, and export private per-action diagnostics. Deliver complete result links without model transcription. Fixes #37. Targets the pinned 29 October 2026 Poppy 0.3 text, Operations 2 and Mediated Sign-In 1.
Why
Our preliminary card asked about an HTTP request before the Company supplied its terms; its intermediate notice could start another model turn. Operations 2 §§1, 4–6 instead lets the Company choose confirmation boundaries.
The live export showed two operation IDs and two 201s without an intervening user-message turn. Missing bodies, order IDs and checkout URLs prevent attributing duplicate live orders/payments or the exact link failure. The truncation and replay defects below are independently reproduced, not explanations asserted for that incident.
How
invalid_sessionrefusal may advance an unapproved task's Session, with account and withdrawal generation unchanged. Recovery republishes committed pending terms without dispatching or deciding them.Testing
0121c85.npm run typecheckandnpm run check:specpassed. Locale was explicitlyen_US.UTF-8; PR Classify unavailable live interop scenarios on Poppy 0.4 #29's locale change is not included.Visual evidence
Claim: the first approval contains the Company's exact terms and price, not a preliminary HTTP request. Activity can now export that action separately.
Input/fixture: the same jacket-exchange prompt and browser fixture, including a synthetic checkout URL beyond 2,000 response characters. The baseline receives the identical test-only response fixture.
Baseline SHA:
4c92a2d890d771feedf7a8fc7274d86644626f70.Current SHA:
0121c85e4a92349f5b99f9c7d1b8ee2212f331b2.Rendered application/fixture SHA:
f8400012a2d17a1f4d05095a98c615ce2be5d48e; the later commit adds evidence/docs only. Receipt, source-tree equality and image hashes.New scoped export surface (unsupported at baseline; no fabricated before image):
Inspect the selected scope and enabled download control. Current checkout-link capture and assertions verify the exact encoded anchor without following it. Regenerate using the recorded commands; the existing renderer tests, transport regressions and strict Company ledger are the independent checks.
Limitation: identities, model and Companies are synthetic. Equality is client-reported telemetry, not server proof of navigation. Browser uncaught errors and strict Company violations/warnings are zero; the local helper prints an RPC-stub disposal warning. None of this verifies live OAuth, checkout or payment, or identifies the live malformed URL.
Risk and rollout
A Company may perform a routine task without another per-write click; keeping it within the User's task remains a model responsibility, not something types prove. The model still cannot approve Company operations. Unknown-outcome holds remain conservative; full automatic same-approval recovery under Ops §7 is not added. Older pending approvals must be requested afresh, without interpreting historical uncertainty as a failed action.
No production order/payment action, schema reset, key rotation or configuration change. PR #29 and its stash are untouched.
Deployment — 30 October 2026
Merged as
4ecbeb99c8e8dbce5449329f5ba5b5b4dea04283, whose tree exactly matches the checked PR head.npm run deploycompleted for poppydemoagent.dev.db0ed1b7-6043-4439-b0bf-a118b0ef8a5e, serving 100% of traffic; deploymentbc825cf8-c43f-41bc-a9b2-e779e59e5241.