Repository navigation
Upload task-selected photos without a redundant approval - #40
Merged
Merged
Conversation
adewale
marked this pull request as ready for review
October 30, 2026 19:37
Owner
Author
|
Merged and deployed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Upload a photo selected for the User's task without repeating its disclosure approval. Keep the decision on the Company's exact terms.
Why
Fixes #39. The extra upload card was our policy, not a Poppy requirement. “Print this photo at this Company” can authorize the needed upload; Poppy Operations requires approval when the Company returns exact terms. There is no quote-before-upload requirement.
Reproduction
With Node 24 and Chromium, attach the fixture's
lake.jpgthrough the real composer and ask for a print. The deployed baseline asks to send the photo, then asks for the Company's $15 terms. This change uploads once and asks only for those terms. The synthetic journey never opens checkout.How
Testing
17c5ba9b2acecf62086b90a4029244871f7b04e2: 2,284 tests / 118 files, none skipped; typecheck, pinned-spec and docs checks pass. Hegel generators/assertions and default case counts are unchanged.91a8536; additional filename/recipient/wrapper regressions were run red before correction. Disabling lifecycle/UI safeguards makes their regressions fail. Disposition.[403,201], reload, exact current checkout receipt, zero strict warnings/violations. Mobile receipt removal fails the final-pin oracle as intended. No checkout navigation.Visual evidence
Claim: this fixture loses the redundant disclosure decision, not the exact price-and-terms decision.
Input/fixture:
photoJourneysandtest/browser/approval-journey-worker.ts; same synthetic photo, model plan and Companies. Production Vite renderer, local workerd, light theme; 1440×1000 and 390×844.Baseline SHA:
4ecbeb99c8e8dbce5449329f5ba5b5b4dea04283.Current SHA:
55934434b3ef62788dcbb36867ab9eff15eaa9ba(evidence/test head; application and harness identical to reviewed17c5ba9b2acecf62086b90a4029244871f7b04e2).Receipt: source/input/artifact hashes and commands. Baseline overlays only the same test harness, not application code.
Independent check:
test/print-journey.test.tsand the browser's current-Company/effect/decision assertions. Full receipts, completed states and privacy renders.Limitation: synthetic signed identity/model only; no live OAuth/provider settings, checkout, charge, print or email verification. Earlier cleanup timeouts are excluded from exit-zero acceptance evidence.
Risk
Selection bounds availability; it is not proof of semantic intent or universal injection immunity. This changes disclosure policy, not Company-terms approval. Unsupported/ambiguous references stay conservative. No old approval migration, schema reset, key rotation or deployment-configuration change. Preserve active request/routing ledgers; do not roll back to an older binary that ignores them. Self-service deletion/export, conversation forgetting, diagnostic TTL and downstream-copy erasure are not implemented; Gateway/provider logging/training/retention remain unverified. No production transaction is authorized by this PR.