Skip to content

Upload task-selected photos without a redundant approval - #40

Merged
adewale merged 10 commits into
mainfrom
fix/task-photo-uploads
Oct 30, 2026
Merged

adewale merged 10 commits into
mainfrom
fix/task-photo-uploads

Conversation

@adewale

@adewale adewale commented Oct 30, 2026 •

Copy link
Copy Markdown
Owner

What

Upload a photo selected for the User's task without repeating its disclosure approval. Keep the decision on the Company's exact terms.

Why

Fixes #39. The extra upload card was our policy, not a Poppy requirement. “Print this photo at this Company” can authorize the needed upload; Poppy Operations requires approval when the Company returns exact terms. There is no quote-before-upload requirement.

Reproduction

With Node 24 and Chromium, attach the fixture's lake.jpg through the real composer and ask for a print. The deployed baseline asks to send the photo, then asks for the Company's $15 terms. This change uploads once and asks only for those terms. The synthetic journey never opens checkout.

How

  • Bind selection to original admitted User inputs and generating-task memos, never summaries, Company notices or a tool's claimed permission. Stop/reset withdraw grants; older admissions are not upgraded.
  • Bound files and recipients separately. Complete names and outer network tokens prevent suffix/query expansion; recipient titles are data. Ambiguous/unselected files keep disclosure consent; website forms are unchanged.
  • Freeze routing, IDs, checked input and authority before asynchronous work. Retire all equivalent disclosure siblings; mapped outcomes precede discovery/file reads. Preserve ownership/expiry/host checks, Session withdrawal, exact terms and unknown-outcome holds.
  • Correct success/unknown/missing-result display and task-versus-human attribution. Correct the privacy policy rather than promise controls that do not exist. Remaining privacy work.

Testing

  • Local application pin 17c5ba9b2acecf62086b90a4029244871f7b04e2: 2,284 tests / 118 files, none skipped; typecheck, pinned-spec and docs checks pass. Hegel generators/assertions and default case counts are unchanged.
  • Reproduced adversarial file/recipient cases and checked mutation-style failures. Eighteen selection regressions fail on otherwise unchanged 91a8536; additional filename/recipient/wrapper regressions were run red before correction. Disabling lifecycle/UI safeguards makes their regressions fail. Disposition.
  • Independent source reviews covered security, lifecycle and policy/UI; actionable findings were fixed. Final security clearance. Reviews are source inspection, not execution evidence.
  • Real local Chromium/workerd: desktop/mobile, real composer, one upload/one exact-terms approval/one approved order request, [403,201], reload, exact current checkout receipt, zero strict warnings/violations. Mobile receipt removal fails the final-pin oracle as intended. No checkout navigation.
  • 16 shared real process-crash probes pass, including unsafe MCP negative control; independent Company ledgers survive. Not a selected-multipart-specific crash matrix.
  • 13 interop cells pass: ten own-project and three pinned Print with Poppy; no unsupported cells, failures or warnings. Docker egress denied; business services are synthetic.
  • CI exposed an invocation-order assumption in an existing feedback race test. A barrier now establishes the intended queued history; original assertions remain. Removing queued rejection recovery makes it fail. Test-only change; application code remains identical to the reviewed pin. Final-head CI must be green before merge.

Visual evidence

Claim: this fixture loses the redundant disclosure decision, not the exact price-and-terms decision.
Input/fixture: photoJourneys and test/browser/approval-journey-worker.ts; same synthetic photo, model plan and Companies. Production Vite renderer, local workerd, light theme; 1440×1000 and 390×844.
Baseline SHA: 4ecbeb99c8e8dbce5449329f5ba5b5b4dea04283.
Current SHA: 55934434b3ef62788dcbb36867ab9eff15eaa9ba (evidence/test head; application and harness identical to reviewed 17c5ba9b2acecf62086b90a4029244871f7b04e2).
Receipt: source/input/artifact hashes and commands. Baseline overlays only the same test harness, not application code.

Before After What to inspect
Desktop before: separate consent to send the selected lake photo Desktop after: photo Done and only the exact 15-dollar Company terms await approval Same task, different progress: extra disclosure disappears; terms remain.
Mobile before: a photo disclosure card blocks progress Mobile after: exact price and terms remain for the sole decision Mobile nested scrolling crops some headings; upload completion is established by assertions and effect counts, not this crop alone.

Independent check: test/print-journey.test.ts and the browser's current-Company/effect/decision assertions. Full receipts, completed states and privacy renders.
Limitation: synthetic signed identity/model only; no live OAuth/provider settings, checkout, charge, print or email verification. Earlier cleanup timeouts are excluded from exit-zero acceptance evidence.

Risk

Selection bounds availability; it is not proof of semantic intent or universal injection immunity. This changes disclosure policy, not Company-terms approval. Unsupported/ambiguous references stay conservative. No old approval migration, schema reset, key rotation or deployment-configuration change. Preserve active request/routing ledgers; do not roll back to an older binary that ignores them. Self-service deletion/export, conversation forgetting, diagnostic TTL and downstream-copy erasure are not implemented; Gateway/provider logging/training/retention remain unverified. No production transaction is authorized by this PR.

@adewale
adewale marked this pull request as ready for review October 30, 2026 19:37
@adewale
adewale merged commit 289c659 into main Oct 30, 2026
2 checks passed
@adewale

adewale commented Oct 30, 2026

Copy link
Copy Markdown
Owner Author

Merged and deployed.

  • Merge 289c6592c6f6e629b1d525247f3c4e2243662bc2; tree exactly matches verified head 55934434b3ef62788dcbb36867ab9eff15eaa9ba. Application/harness unchanged from reviewed runtime pin 17c5ba9.
  • CI: test and interop pass. Final local head: 2,284 tests, none skipped; spec/docs/typecheck pass. Committed evidence: 23 artifact hashes verified.
  • Production https://poppydemoagent.dev — Worker 835a71a0-be0e-4c5e-ad73-ee43a9b48464, verified 100% traffic; deployment 9b5f9726-a3ec-4dc4-b692-5603b104ac92.
  • Public routes/CSP, exact built asset hashes, canonical identity/Operations 2/public-only JWKS, signed-out 401s and workers.dev redirects verified. Live desktop/mobile signed-out rendering and the updated privacy policy pass, with no uncaught browser errors.
  • No authenticated Company flow, checkout, order or payment attempted. Synthetic acceptance does not verify live OAuth/model-provider settings or establish the earlier checkout failure's cause.
  • No schema reset, key rotation or deployment-configuration change. PR29 branch and named stash preserved. Privacy wording is corrected; the deletion/export/retention controls and provider-setting checks in docs/privacy-review.md remain outstanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use task-selected photos without a redundant upload confirmation

1 participant