Skip to content

🎨 Palette: Add confirmation dialog for destructive section delete action#543

Open
aafre wants to merge 2 commits into
mainfrom
palette/destructive-section-delete-modal-4104209271020414094
Open

🎨 Palette: Add confirmation dialog for destructive section delete action#543
aafre wants to merge 2 commits into
mainfrom
palette/destructive-section-delete-modal-4104209271020414094

Conversation

@aafre
Copy link
Copy Markdown
Owner

@aafre aafre commented May 21, 2026

💡 What

Added ResponsiveConfirmDialog to SectionControls.tsx to handle the deletion of custom sections.

🎯 Why

Deleting an entire section from the resume editor was previously instantaneous and irreversible. This micro-UX enhancement introduces a standard confirmation step to prevent accidental data loss when users misclick the trash icon.

📸 Before/After

Before: Clicking the "Delete section" button immediately and permanently removed the section and all its contents.
After: Clicking the "Delete section" button now opens an accessible modal dialog asking the user to confirm their action.

♿ Accessibility

Utilizes the existing ResponsiveConfirmDialog which properly uses the role="dialog" pattern, traps focus, handles escape-key cancellation, and ensures ARIA attributes are wired up correctly for screen readers.


PR created automatically by Jules for task 4104209271020414094 started by @aafre

Co-authored-by: aafre <8656674+aafre@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Co-authored-by: aafre <8656674+aafre@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a confirmation dialog for deleting sections in the SectionControls component and adds several Tiptap-related dependencies to package.json. The review feedback focuses on aligning the versions of the newly added Tiptap packages with existing project dependencies to prevent conflicts and removing a redundant state update in the SectionControls component.

I am having trouble creating individual review comments. Click here to see my feedback.

resume-builder-ui/package.json (30)

high

The version ^3.23.6 for @tiptap/core is inconsistent with the existing Tiptap extensions in this file (e.g., @tiptap/extension-bold at ^3.10.7). Mixing Tiptap versions can lead to peer dependency conflicts, duplicate code in the bundle, and runtime errors. Please align this with the project's current Tiptap version or remove it if it was added accidentally.

    "@tiptap/core": "^3.10.7",

resume-builder-ui/package.json (33)

high

The version ^3.23.6 for @tiptap/extension-document is inconsistent with other Tiptap packages in the project. Please use ^3.10.7 to ensure compatibility across the Tiptap suite.

    "@tiptap/extension-document": "^3.10.7",

resume-builder-ui/package.json (37)

high

The version ^3.23.6 for @tiptap/extension-paragraph is inconsistent with other Tiptap packages. Please align with ^3.10.7 to prevent version mismatch issues.

    "@tiptap/extension-paragraph": "^3.10.7",

resume-builder-ui/package.json (40)

high

The version ^3.23.6 for @tiptap/extension-text is inconsistent with other Tiptap packages. Please align with ^3.10.7 to maintain a consistent dependency tree.

    "@tiptap/extension-text": "^3.10.7",

resume-builder-ui/src/components/SectionControls.tsx (23)

medium

This state update is redundant. The ResponsiveConfirmDialog component already invokes its onClose callback (which sets isConfirmOpen to false) immediately after the onConfirm callback finishes executing. You can safely remove this line to simplify the logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant