🎨 Palette: Add deletion confirmation to array items#498
Conversation
Added ResponsiveConfirmDialog to ExperienceItem, EducationItem, and GenericSection to prevent accidental data loss. Co-authored-by: aafre <8656674+aafre@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a confirmation dialog for deleting entries in the Education, Experience, and Generic sections to prevent accidental data loss. The changes include adding state management for the dialogs in the respective components and updating the test suites to account for the new confirmation step. A review comment suggests clarifying a code comment in GenericSection.tsx to accurately describe the interaction with the parent deletion handler.
| if (onDeleteEntry) { | ||
| // Trigger confirmation dialog | ||
| onDeleteEntry(index); | ||
| // Trigger parent confirmation dialog (or direct action) if provided |
There was a problem hiding this comment.
This comment is confusing because the confirmation has already occurred within this component. It should simply state that it calls the parent's deletion handler.
| // Trigger parent confirmation dialog (or direct action) if provided | |
| // Call parent deletion handler if provided |
|
Closing duplicate — the most recent version of this change is PR #543. |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
1 participant
What
Added
ResponsiveConfirmDialogto confirm deletion of items inExperienceItem,EducationItem, andGenericSection.Why
Prevents accidental data loss by confirming before deleting experience, education, and generic list items. Previously, clicking the delete button removed the item instantly without warning.
Accessibility
Utilized the existing
ResponsiveConfirmDialogwhich already provides appropriaterole="dialog", ARIA attributes, focus management, and mobile-friendly bottom sheet behavior.Before/After
Before: Clicking delete on an item would remove it immediately.
After: A confirmation dialog appears to ensure the user intended to delete the item before it is removed.
PR created automatically by Jules for task 4734394976008816392 started by @aafre