Freeze legacy Kyber output with golden vectors from v1.0.5 #6

Activity

1. Zikithezikit

   added this to the 2.0.0 milestone on Oct 29, 2026
2. Zikithezikit

   added

   enhancementNew feature or requestNew feature or request

   legacy-kyberRound-3 Kyber classes kept for compatibilityRound-3 Kyber classes kept for compatibility

   on Oct 29, 2026
3. Zikithezikit

   added a parent issue on Oct 29, 2026

   • [2.0] Add ML-KEM (FIPS 203) support while keeping legacy Kyber API with deprecation #3
4. Zikithezikit

   marked this as blocked on Oct 29, 2026

   • Fix the failing Kyber-1024 params test #5
5. Zikithezikit

   marked this as blocking on Oct 29, 2026

   • Figure out which Kyber primitives ML-KEM can reuse #8
6. Zikithezikit commented on Oct 29, 2026

   

   Zikithezikit

   on Oct 29, 2026

   OwnerAuthor

   More actions

   Filed as PR #22 (branch wp6-golden-vectors, based on dev-v2 at 6e29bef; please review and rebase-merge, nothing is merged by me).

   • tests/vectors/legacy-kyber-v1.0.5.json (append-only) now holds 9 golden vectors (3 seeds x 3 parameter sets) captured on 2026-10-29 from the pinned PyPI wheel pykyber 1.0.5 (sha256 0bd5d644...) and from a cargo --release run in a worktree of the v1.0.5 tag. The generator (tests/vectors/generate.py) cross-checks the 1.0.5 Python layer against the 1.0.5 Rust core before writing.
   • Rust tests/legacy_vectors.rs and python/tests/test_legacy_vectors.py replay seeded keygen, seeded encapsulation, and decapsulation against the file; the record also covers Python from_keys and an encapsulate/decapsulate roundtrip over v1.0.5 key material.
   • Acceptance check from the issue passed review testing: with KYBER_Q changed 3329 -> 3331 in src/kyber/params.rs, cargo test --test legacy_vectors fails at vector #0 and 36 of 37 of the new Python tests fail. Reverted afterwards; suite green again.
   • Per-commit verification ran with git rebase --exec as in AGENTS.md (cargo fmt --check, cargo test --no-fail-fast, maturin develop, pytest): commit 1 is green with 158 Python tests, commit 2 with 195. Clippy stays at the pre-existing 57 diagnostics; no new ones from the files in this PR.
   • Source check (PLAN-2.0.md section 9, 2026-10-29): NVD keyword search for "pykyber" and "CRYSTALS-Kyber" found no advisories; RustSec has none for pykyber; the PyPI 1.0.5 wheel hashes to the pinned sha256; no change, nothing needs redoing. The pq-crystals round-3 PDF link currently 404s and was not relied on; the capture authority is the 1.0.5 artifact itself.
   • Out of scope, as planned: declaring pytest/maturin as dev deps and the CI test job (issue CI: run tests and lints on every PR #7); clippy cleanup (its own PR before issue CI: run tests and lints on every PR #7); Cargo.lock stale-entry cleanup (chore PR still owed).
7. Zikithezikit commented on Oct 30, 2026

   

   Zikithezikit

   on Oct 30, 2026

   OwnerAuthor

   More actions

   Done in 7434f3d and 2716829 (golden vectors from v1.0.5 plus the Rust and Python checks). Both suites pass on dev-v2 and now run in CI on every commit of a PR.
8. Zikithezikit

   closed this as completedon Oct 30, 2026