You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
cargo test fails on tests/unit_params.rs::test_kyber_1024_params: it expects 1280 and gets 1408. I don't know yet whether the test or the constant is wrong.
Please work out which value is right from the Kyber round-3 spec before changing anything, and say in the PR which one was wrong and why. Don't just change the assertion to match the code.
If the constant turns out to be wrong, stop and tell me before fixing it, because that would change Kyber-1024 output and we need to talk about what that means for 1.x users.
Also: the committed Cargo.lock still says version 0.1.7 while the package is 1.0.5, so any cargo command changes it. Commit the synced lockfile on its own first (chore: sync Cargo.lock with 1.0.5) so it doesn't get mixed into the fix.
Done when: cargo test --no-fail-fast is green and the PR explains the fix with a link to the spec.
Activity
test: fix Kyber-1024 compression byte sizes per Kyber round-3 spec
test: fix Kyber-1024 compression byte sizes per Kyber round-3 spec