Skip to content

Fix the failing Kyber-1024 params test #5

Closed

Description

@Zikithezikit

cargo test fails on tests/unit_params.rs::test_kyber_1024_params: it expects 1280 and gets 1408. I don't know yet whether the test or the constant is wrong.

Please work out which value is right from the Kyber round-3 spec before changing anything, and say in the PR which one was wrong and why. Don't just change the assertion to match the code.

If the constant turns out to be wrong, stop and tell me before fixing it, because that would change Kyber-1024 output and we need to talk about what that means for 1.x users.

Also: the committed Cargo.lock still says version 0.1.7 while the package is 1.0.5, so any cargo command changes it. Commit the synced lockfile on its own first (chore: sync Cargo.lock with 1.0.5) so it doesn't get mixed into the fix.

Done when: cargo test --no-fail-fast is green and the PR explains the fix with a link to the spec.

Part of #3.

Activity

  1. added this to the 2.0.0 milestone on Oct 29, 2026
  2. added
    bugSomething isn't working
    legacy-kyberRound-3 Kyber classes kept for compatibility
    on Oct 29, 2026
  3. added a commit that references this issue on Oct 29, 2026
    6e29bef
  4. added a commit that references this issue on Oct 31, 2026
    538a7d4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinglegacy-kyberRound-3 Kyber classes kept for compatibility

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions