Skip to content

fix(backend): migrate rand call sites to 0.10 - #3300

Merged
Xore merged 1 commit into
mainfrom
issue-3299-coder
Sep 25, 2026
Merged

Xore merged 1 commit into
mainfrom
issue-3299-coder

Conversation

@Xore

@Xore Xore commented Sep 25, 2026

Copy link
Copy Markdown
Owner

Summary

  • migrate backend-service rand imports to the 0.10 trait names
  • preserve existing random byte and password generation behavior

Validation

  • cargo check --manifest-path arcane/home/honeypot-dashboard/backend-service/Cargo.toml
  • cargo test --manifest-path arcane/home/honeypot-dashboard/backend-service/Cargo.toml (519 passed, 1 ignored)

Closes #3299

@github-actions

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@Xore
Xore merged commit 7a31902 into main Sep 25, 2026
201 of 210 checks passed
@Xore
Xore deleted the issue-3299-coder branch September 25, 2026 11:44
Xore added a commit that referenced this pull request Sep 26, 2026
…old 0.x minor bumps (#3336)

* ci: always-reporting Quality/Containers gates for the main ruleset; hold 0.x minor bumps

main had no branch protection, so dependabot's `gh pr merge --auto` merged
on the spot: five PRs landed on 2026-09-25 with red Rust and container
checks, and main's backend stayed broken until #3300.

A ruleset needs contexts that report on every PR. Quality's jobs come in
homeserver/GitHub-hosted pairs and Containers' rows carry a "(GitHub-hosted)"
suffix on fallback days, so no individual job name is stable. Add:

- quality-gate ("Quality gate"): success iff the router succeeded and every
  pair produced a homeserver success or a skip + fallback success, plus the
  existing Go and Scripts aggregates. always(), so a failed router reports
  red rather than pending.
- containers-gate ("Containers gate"): router and every image row succeeded.

dependabot-auto-merge: hold any update that moves a 0.x dependency's minor
version (grouped PRs: any member). fetch-metadata labels 0.9 -> 0.10
semver-minor although semver and Cargo treat it as breaking; that is how
rand (#3287) and sha2 (#3289) qualified.

docs/CI-CD.md: document the ruleset and its required contexts, correct the
Dependabot paragraph that claimed protection already existed.

Refs #3311

* docs(ci): name the Scripts and Compose matrix by job id, not a path-like token

Refs #3311
Xore added a commit that referenced this pull request Sep 26, 2026
…heads CI never ran on (#3355)

Two failure modes, one of which the 2026-09-25 incident turns out to have
been. A red push run on main is read by nobody; and a merge made by
github-actions (dependabot auto-merge) starts no push run at all, because
GITHUB_TOKEN events trigger no workflows -- the five broken dependabot
merges that day produced no red run, only silence, until #3300's push.

scripts/main-health-watch.py, run after every Quality/Containers run on
main and hourly:
- red: one main-red-alarm issue with the failing jobs, first red / last
  green commit and the commits between; a new comment only when the failing
  head changes; closed automatically when both workflows are green again.
  Cancelled runs are ignored.
- untested: main's head older than an hour with no run of a watched
  workflow gets that workflow dispatched on main (workflow_dispatch is the
  event GITHUB_TOKEN may start); dispatched runs are judged like push runs.
- --before ISO8601 replays any past moment read-only. Replaying 2026-09-25
  10:00Z flags 87df7e1 (the sha2 bump) as untested; 06:40Z is inside the
  grace hour; now is green.

8 tests against a fake gh cover open, dedupe, append, close, cancelled
runs, dispatch, the grace period and dispatched runs counting.

Closes #3324
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

main does not compile: rand 0.10 breaking bump landed without call-site migration

1 participant