ci: always-reporting Quality/Containers gates for the main ruleset; hold 0.x minor bumps - #3336
Merged
Merged
Conversation
…old 0.x minor bumps main had no branch protection, so dependabot's `gh pr merge --auto` merged on the spot: five PRs landed on 2026-09-25 with red Rust and container checks, and main's backend stayed broken until #3300. A ruleset needs contexts that report on every PR. Quality's jobs come in homeserver/GitHub-hosted pairs and Containers' rows carry a "(GitHub-hosted)" suffix on fallback days, so no individual job name is stable. Add: - quality-gate ("Quality gate"): success iff the router succeeded and every pair produced a homeserver success or a skip + fallback success, plus the existing Go and Scripts aggregates. always(), so a failed router reports red rather than pending. - containers-gate ("Containers gate"): router and every image row succeeded. dependabot-auto-merge: hold any update that moves a 0.x dependency's minor version (grouped PRs: any member). fetch-metadata labels 0.9 -> 0.10 semver-minor although semver and Cargo treat it as breaking; that is how rand (#3287) and sha2 (#3289) qualified. docs/CI-CD.md: document the ruleset and its required contexts, correct the Dependabot paragraph that claimed protection already existed. Refs #3311
Xore
added
ops
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prerequisite for the
mainruleset in #3311.mainhas no protection today, so Dependabot'sgh pr merge --automerges immediately; five PRs landed 2026-09-25 with red checks (#3285, #3287, #3288, #3289, #3291) and the backend stayed broken until #3300.Quality gate(quality.yml): one always-reporting context. Passes only when the router succeeded and each job pair produced a homeserver success or skip + GitHub-hosted success, plus the existingGo formatting and tests/Scripts and Composeaggregates.Containers gate(containers.yml): router and every image row succeeded.fetch-metadatacallsrand 0.9 → 0.10semver-minor) and comments instead of approving.The ruleset itself is created after this merges. Requiring
Quality gatebefore the job exists onmainwould leave every open PR pending.Security impact
.envfiles were added.Validation
actionlint 1.7.7on all three workflows: no new findings (only the existing info-level SC2086 at quality.yml:201/219).needsresults: all-green homeserver → pass; all-green fallback → pass; homeserver twin failed → fail; fallback twin failed → fail; router failed and everything skipped → fail; Go aggregate failed → fail; cancelled → fail.rand 0.9.5 → 0.10.2held;serde 1.0 → 1.1andtokio 0.2.1 → 0.2.3(patch) not held; empty metadata not held.Refs #3311