Fix version parsing for Paper 26+ and null fallback#76
Merged
Conversation
Bukkit.getBukkitVersion() on Paper 26.1.2 no longer matches the legacy "<mc>-R<api>-SNAPSHOT" format, so the substring-based parser produced a StringIndexOutOfBoundsException. Replace it with a regex that extracts only the leading numeric version, tolerating arbitrary suffixes. The catch-block fallback referenced v1_13, but the constants were declared after the static block, leaving them null at fallback time and causing a NullPointerException on the isAbove_1_13 initializer. Move the version constants above the static block so the fallback actually yields a usable Version. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bukkit.getBukkitVersion()on Paper 26.1.2 no longer matches the legacy<mc>-R<api>-SNAPSHOTformat, causingStringIndexOutOfBoundsExceptioninVersion.<clinit>. Replaced the substring parser with a regex that extracts the leading numeric version and tolerates arbitrary suffixes.Version.v1_13, but the constants were declared after the static block — so on any parse failureCURRENTbecamenulland theisAbove_1_13initializer threwNullPointerException. Moved the version constants above the static block so the fallback actually works.Test plan