Fix version parsing for Paper 26+#1
Merged
Conversation
Bukkit.getBukkitVersion() on Paper 26.1.2 no longer matches the legacy "<mc>-R<api>-SNAPSHOT" format, so the substring-based parser produced a StringIndexOutOfBoundsException, preventing the plugin from enabling. Replace it with a regex that extracts only the leading numeric version, tolerating arbitrary suffixes, and add a safe fallback so a parsing failure no longer aborts onEnable(). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bukkit.getBukkitVersion()on Paper 26.1.2 no longer matches the legacy<mc>-R<api>-SNAPSHOTformat (it now looks like26.1.2-build.41-alpha), sovstring.substring(0, vstring.lastIndexOf("-R"))produced aStringIndexOutOfBoundsExceptionand abortedonEnable().1.20fallback so a future format change can no longer prevent the plugin from enabling.Mirrors the equivalent fix in PowerBoard (Xitee1/PowerBoard#76).
Fixes the crash:
Test plan
StringIndexOutOfBoundsExceptionMain.MCVersionis set to a numeric string like26.1.2🤖 Generated with Claude Code