Repository navigation
Spell newbalance correctly in the 0616 config name - #14
Merged
Merged
Conversation
The file shipped as `..._newbalacne_..._0616_h100.yaml` - a transposition that
made the *misspelled* name the working one, so every command in the README had
to carry the typo to run at all. The dataset it trains on was always spelled
correctly (`Xense/newbalance_shoe_insole_retrieval_and_packing_0611`); only the
config filename was wrong.
Renamed the file and the nine README references that had to match it.
A config's name is also its assets directory, so this rename moves where
`compute_norm_stats` output is looked up. On the one machine that had artifacts
under the old spelling, both were renamed alongside (same filesystem, so a
rename, not a copy):
assets/..._newbalacne_..._0616_h100/ -> ..._newbalance_...
checkpoints/..._newbalacne_..._0616_h100/ -> ..._newbalance_... (30 GB)
including the inner `..._0701` run directory, so the `--policy.dir` path the
README documents matches what is on disk. Verified afterwards that the config
resolves and its norm stats are found. Neither the H200 nor ebcloud had anything
under the old name.
`docs/yaml_config_changelog.md` keeps its three `newbalacne` mentions. They are
the historical record of a *different* file - `..._newbalacne_..._0515_h100.yaml`,
deleted during the YAML migration - and rewriting a changelog's account of what
a file used to be called would make it wrong.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #13, where I flagged this and corrected the references rather than the file.
The config shipped as
..._newbalacne_..._0616_h100.yaml— a transposition that made the misspelled name the working one, so every command in the README had to carry the typo to run at all. The dataset it trains on was always spelled correctly (Xense/newbalance_shoe_insole_retrieval_and_packing_0611); only the config filename was wrong.Renamed the file, and the nine README references that had to match it.
The part that isn't just a rename
A config's name is also its assets directory —
assets/<config_name>/is wherecompute_norm_statswrites and whereDataConfiglooks. So this rename moves where norm stats are found.Exactly one machine had artifacts under the old spelling (checked all three; the H200 and ebcloud had nothing). Both were renamed alongside — same filesystem, so a rename rather than a copy:
including the inner
..._0701run directory, so the--policy.dirpath the README documents matches what is actually on disk. Verified afterwards:If anyone else has a local
assets/orcheckpoints/directory under the old spelling, they need the same twomvs — those directories are gitignored, so this PR cannot do it for them.Not touched
docs/yaml_config_changelog.mdkeeps its threenewbalacnementions. They are the historical record of a different file —..._newbalacne_..._0515_h100.yaml, deleted during the YAML migration — and rewriting a changelog's account of what a file used to be called would make it wrong.Verification
all_configs(): no stale namesruff check .clean,pytest src/openpi/training/54 passed🤖 Generated with Claude Code