Skip to content

chore: pin saorsa-core and saorsa-transport to always-masque-relay branches #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jacderida merged 4 commits into from
Apr 22, 2026
+43 −25
Merged

chore: pin saorsa-core and saorsa-transport to always-masque-relay branches #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
197c31d
update dependencies: switch saorsa-core and saorsa-transport to git s…
mickvandijke Apr 21, 2026
eda757f
update dependencies: bump crate versions in Cargo.lock to match lates…
mickvandijke Apr 21, 2026
5ba564a
update dependencies: bump ruint to 1.18.0 and saorsa-core to latest g…
mickvandijke Apr 22, 2026
5d25e1f
update dependencies: bump saorsa-core to latest git commit
mickvandijke Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 42 additions & 24 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ path = "src/bin/ant-devnet/main.rs"

[dependencies]
# Core (provides EVERYTHING: networking, DHT, security, trust, storage)
saorsa-core = "0.23.1"
saorsa-core = { git = "https://github.com/saorsa-labs/saorsa-core.git", branch = "mick/always-masque-relay-rebased" }
Copy link

Copilot AI Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a moving git branch for saorsa-core means dependency resolution can change whenever the branch tip changes (e.g., when regenerating Cargo.lock or building in environments that don't respect the existing lockfile). If you want deterministic builds, prefer pinning to a specific rev (and optionally keep the branch name in a comment) and/or include a version = "..." constraint so Cargo can verify the expected crate version.

Suggested change
saorsa-core = { git = "https://github.com/saorsa-labs/saorsa-core.git", branch = "mick/always-masque-relay-rebased" }
# Pin to the exact vetted commit from the former `mick/always-masque-relay-rebased` branch.
saorsa-core = { git = "https://github.com/saorsa-labs/saorsa-core.git", rev = "REPLACE_WITH_CURRENT_VETTED_COMMIT_SHA" }

Copilot uses AI. Check for mistakes.
saorsa-pqc = "0.5"
Comment on lines 25 to 28
Copy link

Copilot AI Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title/description says both saorsa-core and saorsa-transport are pinned to the mick/always-masque-relay-rebased branch, but this Cargo.toml change only pins saorsa-core. If the intent is to force saorsa-transport to that branch even if it later stops being a git transitive dep of saorsa-core, add an explicit override (e.g. a [patch.crates-io] entry for saorsa-transport or a direct dependency) rather than relying on the current lockfile resolution.

Copilot uses AI. Check for mistakes.

# Payment verification - autonomi network lookup + EVM payment
Expand Down
Loading