chore: pin saorsa-core and saorsa-transport to always-masque-relay branches#76
chore: pin saorsa-core and saorsa-transport to always-masque-relay branches#76
Conversation
…ources, add enum_dispatch
There was a problem hiding this comment.
Pull request overview
This PR switches the project to consume the “always-on MASQUE relay” work by moving Saorsa dependencies off crates.io and onto a specific git branch, updating the lockfile accordingly.
Changes:
- Pin
saorsa-coretohttps://github.com/saorsa-labs/saorsa-core.giton branchmick/always-masque-relay-rebased. - Update
Cargo.lockto resolvesaorsa-coreandsaorsa-transportfrom git (and pull inenum_dispatchtransitively).
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Cargo.toml | Switches saorsa-core dependency from crates.io to a git branch. |
| Cargo.lock | Updates resolved dependency graph for the git-sourced Saorsa crates and adds enum_dispatch. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| [dependencies] | ||
| # Core (provides EVERYTHING: networking, DHT, security, trust, storage) | ||
| saorsa-core = "0.23.1" | ||
| saorsa-core = { git = "https://github.com/saorsa-labs/saorsa-core.git", branch = "mick/always-masque-relay-rebased" } | ||
| saorsa-pqc = "0.5" |
There was a problem hiding this comment.
PR title/description says both saorsa-core and saorsa-transport are pinned to the mick/always-masque-relay-rebased branch, but this Cargo.toml change only pins saorsa-core. If the intent is to force saorsa-transport to that branch even if it later stops being a git transitive dep of saorsa-core, add an explicit override (e.g. a [patch.crates-io] entry for saorsa-transport or a direct dependency) rather than relying on the current lockfile resolution.
| [dependencies] | ||
| # Core (provides EVERYTHING: networking, DHT, security, trust, storage) | ||
| saorsa-core = "0.23.1" | ||
| saorsa-core = { git = "https://github.com/saorsa-labs/saorsa-core.git", branch = "mick/always-masque-relay-rebased" } |
There was a problem hiding this comment.
Using a moving git branch for saorsa-core means dependency resolution can change whenever the branch tip changes (e.g., when regenerating Cargo.lock or building in environments that don't respect the existing lockfile). If you want deterministic builds, prefer pinning to a specific rev (and optionally keep the branch name in a comment) and/or include a version = "..." constraint so Cargo can verify the expected crate version.
| saorsa-core = { git = "https://github.com/saorsa-labs/saorsa-core.git", branch = "mick/always-masque-relay-rebased" } | |
| # Pin to the exact vetted commit from the former `mick/always-masque-relay-rebased` branch. | |
| saorsa-core = { git = "https://github.com/saorsa-labs/saorsa-core.git", rev = "REPLACE_WITH_CURRENT_VETTED_COMMIT_SHA" } |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
saorsa-core(0.23.1 → git, branchmick/always-masque-relay-rebased) andsaorsa-transport(registry → git, same branch) to consume the always-on MASQUE relay work ahead of a published release.enum_dispatchas a new transitive dependency viasaorsa-transport.Test plan
cargo build --releasecargo testcargo clippy --all-features -- -D clippy::panic -D clippy::unwrap_used -D clippy::expect_used🤖 Generated with Claude Code