Skip to content

Guard #onWmeSelectionChanged against unsupported SDK selection types #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JS55CT wants to merge 4 commits into
base: master
Choose a base branch
from
+13 −7
Open

Guard #onWmeSelectionChanged against unsupported SDK selection types #13

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
798d579
Guard #onWmeSelectionChanged against unsupported SDK selection types
JS55CT Mar 26, 2026
14880aa
Merge branch 'WazeDev:master' into master
JS55CT Mar 26, 2026
2901d7f
Added Gard for all sdk.Editing.getSelections()
JS55CT Mar 26, 2026
d9eb063
Merge branch 'master' of https://github.com/JS55CT/WME-Utils
JS55CT Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions SDKGoogleLinkEnhancer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// ==UserScript==
// @name WME Utils - SDK Google Link Enhancer
// @namespace WazeDev
// @version 2026.03.23.00
// @version 2026.03.26.1
// @description Adds some extra WME functionality related to Google place links.
// @author WazeDev group
// @include /^https:\/\/(www|beta)\.waze\.com\/(?!user\/)(.{2,6}\/)?editor\/?.*$/
Expand Down Expand Up @@ -253,7 +253,8 @@ const SDKGoogleLinkEnhancer = (() => {
})(jQuery);
/* eslint-enable wrap-iife, func-names, object-shorthand */
// In case a place is already selected on load.
const currentSelection = this.sdk.Editing.getSelection();
let currentSelection;
try { currentSelection = this.sdk.Editing.getSelection(); } catch (e) { currentSelection = null; }
if (currentSelection?.ids?.length && currentSelection.objectType === "venue") {
this.#formatLinkElements();
}
Expand Down Expand Up @@ -289,7 +290,8 @@ const SDKGoogleLinkEnhancer = (() => {
#onWmeSelectionChanged() {
if (this.#enabled) {
this.#destroyPoint();
const selected = this.sdk.Editing.getSelection();
let selected;
try { selected = this.sdk.Editing.getSelection(); } catch (e) { return; }
if (selected?.objectType === "venue") {
// The setTimeout is necessary (in beta WME currently, at least) to allow the
// panel UI DOM to update after a place is selected.
Expand Down Expand Up @@ -616,7 +618,8 @@ const SDKGoogleLinkEnhancer = (() => {
.attr("title", this.strings.badLink);
}
else {
const selection = this.sdk.Editing.getSelection();
let selection;
try { selection = this.sdk.Editing.getSelection(); } catch (e) { selection = null; }
if (selection?.objectType === "venue") {
const venue = this.sdk.DataModel.Venues.getById({ venueId: selection.ids[0] });
if (venue && this.#isLinkTooFar(link, venue)) {
Expand Down Expand Up @@ -645,7 +648,8 @@ const SDKGoogleLinkEnhancer = (() => {
throw new Error(msg);
}
const existingLinks = {};
const thisVenue = sdk.Editing.getSelection();
let thisVenue;
try { thisVenue = sdk.Editing.getSelection(); } catch (e) { return {}; }
if (thisVenue?.objectType !== "venue")
return {};
for (const venue of sdk.DataModel.Venues.getAll()) {
Expand Down Expand Up @@ -690,7 +694,8 @@ const SDKGoogleLinkEnhancer = (() => {
if (!link.notFound) {
const coord = link.loc;
const poiPt = this.trf.point([coord.lng, coord.lat]);
const selection = this.sdk.Editing.getSelection();
let selection;
try { selection = this.sdk.Editing.getSelection(); } catch (e) { selection = null; }
let placeGeom;
if (selection?.objectType === "venue") {
const v = this.sdk.DataModel.Venues.getById({ venueId: selection.ids[0] });
Expand Down Expand Up @@ -784,7 +789,8 @@ const SDKGoogleLinkEnhancer = (() => {
}
#getIdFromElement($el) {
const providerIndex = $el.parent().children().toArray().indexOf($el[0]);
const selection = this.sdk.Editing.getSelection();
let selection;
try { selection = this.sdk.Editing.getSelection(); } catch (e) { return null; }
if (!selection || selection.objectType !== "venue") return null;
const venue = this.sdk.DataModel.Venues.getById({ venueId: selection.ids[0] });
return venue?.externalProviderIds?.[providerIndex] ?? null;
Expand Down