Guard #onWmeSelectionChanged against unsupported SDK selection types#13
Open
JS55CT wants to merge 4 commits intoWazeDev:masterfrom
Open
Guard #onWmeSelectionChanged against unsupported SDK selection types#13JS55CT wants to merge 4 commits intoWazeDev:masterfrom
JS55CT wants to merge 4 commits intoWazeDev:masterfrom
Conversation
Waze recently added Google Places as a clickable layer in WME. When a Google Place is selected, sdk.Editing.getSelection() throws WMEError: Selection contains an unexpected object type googlePlace because googlePlace is defined in ObjectType but is not in the SDK's SELECTABLE_OBJECT_TYPES list. The wme-selection-changed event fires for all selection changes (including Google Places), but since the event payload is always undefined, there is no way to pre-screen the type before calling getSelection(). The only reliable guard is a try/catch. SDKGoogleLinkEnhancer only operates on venue selections, so returning early on any unsupported type is the correct behavior — nothing is lost. Before: #onWmeSelectionChanged called this.sdk.Editing.getSelection() unguarded, throwing an unhandled exception on every Google Place click. After: The call is wrapped in try/catch; on error the handler returns silently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Waze recently added Google Places as a clickable layer in WME. When a Google Place is selected, sdk.Editing.getSelection() throws WMEError: Selection contains an unexpected object type googlePlace because googlePlace is defined in ObjectType but is not in the SDK's SELECTABLE_OBJECT_TYPES list.
The wme-selection-changed event fires for all selection changes (including Google Places), but since the event payload is always undefined, there is no way to pre-screen the type before calling getSelection(). The only reliable guard is a try/catch.
SDKGoogleLinkEnhancer only operates on venue selections, so returning early on any unsupported type is the correct behavior — nothing is lost.
Before: #onWmeSelectionChanged called this.sdk.Editing.getSelection() unguarded, throwing an unhandled exception on every Google Place click.
After: The call is wrapped in try/catch; on error the handler returns silently.