Skip to content

fix(security): scrub the three remaining log-injection sites #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VortexUK merged 1 commit into from
Jul 11, 2026
Merged

fix(security): scrub the three remaining log-injection sites #159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion backend/server/api/aa.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,9 @@ async def get_spell_effects(spellcrc: int, tier: int = 0) -> SpellEffectsRespons
try:
effects = json.loads(row.get("effects", "[]"))
except Exception as exc:
_log.warning("[aa] Failed to parse effects JSON for crc=%s tier=%s: %s", spellcrc, tier, exc)
_log.warning(
"[aa] Failed to parse effects JSON for crc=%s tier=%s: %s", scrub(spellcrc), scrub(tier), exc
)
effects = []

return SpellEffectsResponse(
Expand Down
2 changes: 1 addition & 1 deletion backend/server/cache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ def get(self, key: str) -> Any | None:
self._update_size()
self._inc_miss()
return None
_log.debug("[cache] HIT %s", key)
_log.debug("[cache] HIT %s", scrub(key))
self._inc_hit()
return value

Expand Down
Loading