fix(security): scrub the three remaining log-injection sites#159
Merged
Conversation
The refreshed main CodeQL analysis (post-#158) left three live alerts: the cache HIT log (one key log site missed in #158) and the aa.py effects-parse warning (crc/tier are FastAPI-typed ints that cannot carry CRLF, but scrub is free and clears the taint). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #158: the refreshed main analysis closed 29 of 32 alerts; these are the last three live sites — the cache HIT key log (missed in the first sweep) and aa.py's effects-parse warning (crc/tier are typed ints, scrubbed anyway to clear the taint). Will re-dispatch the main analysis after merge to confirm zero open alerts.
🤖 Generated with Claude Code