Skip to content

fix(apollo-wind): build the field header actions on the 3xs Button [MST-16146] - #1456

Open
BenGSchulz wants to merge 1 commit into
mainfrom
fix/field-header-action-sizes
Open

BenGSchulz wants to merge 1 commit into
mainfrom
fix/field-header-action-sizes

Conversation

@BenGSchulz

@BenGSchulz BenGSchulz commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Summary

FormFieldHeader's row is min-h-6, the height of a 3xs Button, but the header actions were hand-built 28px buttons, so every header that carried them grew to 28px (MST-16146).

  • AiAssistAction and InsertVariableAction, and QuickFormField's field type and compact Required triggers, are now ghost size="3xs" Buttons sharing one FIELD_ACTION_CLASS, with 12px icons.
  • Headers with actions are now the 24px row FormFieldHeader expects. Collapsed actions are 24×24.
  • COLLAPSED_ICON_PADDING is gone, as the 3xs padding already matches it. COLLAPSED_ONLY shows as flex, so the compact Required trigger's wrapper adds no line box.
  • The QuickFormField story's Delete header action uses the same Button.

Decisions worth a look

  • The header is denser. It drops from 28px to 24px, and the trigger text goes from 11px regular to the 3xs 12px medium. This also applies to forms/field-actions and the form designer, which use the same two actions.
  • The tone follows FieldMenu: text-muted-foreground with an accent hover, instead of foreground-subtle with a surface-overlay hover.

Demo

Also fixes a jump / inconsistent header heights when removing actions

Before:

Screen.Recording.2026-10-22.at.3.11.31.PM.mov

After:

Screen.Recording.2026-10-22.at.3.12.42.PM.mov

Test plan

  • apollo-wind: 3,044 tests pass, typecheck clean, Biome clean on changed files
  • Storybook: QuickFormField Default and Responsive (full width, narrow, compact) and FormField FullField headers measure 24px, collapsed actions 24×24
  • hitl-schema preview, via a local build: every header action is 24×24

Stack

  1. fix(apollo-wind): build the field header actions on the 3xs Button [MST-16146] #1456: Field header actions on the 3xs Button ← this PR
  2. feat(apollo-wind): built-in variable and prompt modes in QuickFormField [MST-16146] #1440: Built-in variable and prompt modes
  3. feat(apollo-wind): EditableText, and an editable label in QuickFormField [MST-16146] #1441: EditableText and an editable label
  4. refactor(apollo-react): build the canvas EditableText on apollo-wind's [MST-16146] #1442: Canvas EditableText on apollo-wind's

🤖 Generated with Claude Code

…ST-16146]

FormFieldHeader's row is `min-h-6`, the height of a `3xs` Button, but the
AI assist and Insert variable actions, and QuickFormField's field type and
compact Required triggers, were hand-built 28px buttons. Every header that
carried them grew to 28px, and a layout that hid them had to restate that
height to keep the row still.

They are now ghost `3xs` Buttons in the muted tone of the field's other
icon buttons, with 12px icons, so the header is the 24px row it is meant
to be. The 3xs padding is already the collapsed padding, so the collapsed
padding override goes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings October 22, 2026 21:59

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

Copy link
Copy Markdown
Contributor

Dependency License Review

  • ✅ 1957 package(s) scanned
  • ✅ No license issues found
  • ⚠️ 2 package(s) excluded (see details below)
License distribution
License Packages
MIT 1721
ISC 91
Apache-2.0 57
BSD-3-Clause 28
BSD-2-Clause 23
BlueOak-1.0.0 8
MPL-2.0 4
CC0-1.0 4
MIT-0 3
MIT OR Apache-2.0 2
(MIT OR Apache-2.0) 2
Unlicense 2
LGPL-3.0-or-later 1
Python-2.0 1
CC-BY-4.0 1
(MPL-2.0 OR Apache-2.0) 1
Unknown 1
Artistic-2.0 1
(WTFPL OR MIT) 1
(BSD-2-Clause OR MIT OR Apache-2.0) 1
CC-BY-3.0 1
0BSD 1
(MIT OR CC0-1.0) 1
MIT AND ISC 1
Excluded packages
Package Version License Reason
@img/sharp-libvips-linux-x64 1.3.4 LGPL-3.0-or-later LGPL pre-built binary, not linked
khroma 2.1.0 Unknown MIT per GitHub repo, missing license field in package.json

@github-actions

Copy link
Copy Markdown
Contributor

Storybook visual diff

⚠️ Visual changes detected: 28 changed (of 100 compared, 72 unchanged). View report

Baseline is the deployed main Storybook, so changes merged to main after this branch was last updated can also appear here. Logs

Updated (PT): Oct 22, 2026, 03:21:00 PM

@github-actions

Copy link
Copy Markdown
Contributor

📊 Coverage + size by package

Per-package coverage and bundle size on this PR. New-line coverage = of the source lines this PR adds or changes, the % hit by tests.

Package Coverage New-line coverage Packed (gzip) Unpacked vs main
@uipath/apollo-core — — 42.02 MB 50.17 MB ±0
@uipath/apollo-react 58.1% — 8.14 MB 32.17 MB −21 B
@uipath/apollo-ui-icons — — 2.86 MB 6.97 MB ±0
@uipath/apollo-vertex — — — — —
@uipath/apollo-wind 79.4% 100.0% (3/3) 810.6 KB 4.68 MB −87 B
@uipath/ap-chat 85.8% — 40.42 MB 45.71 MB ±0

"Coverage" is each package's own coverage.include scope (e.g. apollo-core instruments only scripts/). "Packed"/"Unpacked" come from npm pack --dry-run and only cover built packages — "—" means not measured this run (package not affected / not built). "vs main" is the packed (gzipped) delta against the last successful main build (the package-sizes artifact from the Release workflow); "—" there means no main baseline was available this run. The baseline is main's latest build, not this PR's exact merge-base, so it includes any drift since the branch diverged. Packages with no vitest config are omitted.

This branch was successfully deployed

4 active deployments
preview/apollo-design — da91ce2a Deployed Oct 22, 2026 by github-actions[bot]
preview/apollo-landing — da91ce2a Deployed Oct 22, 2026 by github-actions[bot]
preview/apollo-vertex — da91ce2a Deployed Oct 22, 2026 by github-actions[bot]
preview/apollo-docs — da91ce2a Deployed Oct 22, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg:apollo-wind size:M 30-99 changed lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants