Repository navigation
refactor(apollo-react): build the canvas EditableText on apollo-wind's [MST-16146] - #1442
Open
BenGSchulz wants to merge 1 commit into
Open
BenGSchulz wants to merge 1 commit into
BenGSchulz wants to merge 1 commit into
Conversation
Contributor
Dependency License Review
License distribution
Excluded packages
|
Contributor
📊 Coverage + size by packagePer-package coverage and bundle size on this PR. New-line coverage = of the source lines this PR adds or changes, the % hit by tests.
"Coverage" is each package's own |
BenGSchulz
marked this pull request as ready for review
October 22, 2026 01:20
BenGSchulz
force-pushed
the
refactor/canvas-editable-text
branch
from
October 22, 2026 18:56
ffa426f to
f618049
Compare
…s [MST-16146] The canvas EditableText duplicated the click-to-edit text now in apollo-wind. It becomes a thin wrapper that adds React Flow's `nodrag` and `nowheel` classes, so dragging or scrolling over the text leaves the canvas alone. Its name, export and props are unchanged. The overflow tooltip now comes from apollo-wind's `truncationTooltip` instead of CanvasTooltip, with the same 700ms delay. The read trigger and static text also gain `nowheel`, which only the editor had before. The behaviour tests moved to apollo-wind with the component; the canvas tests cover what the wrapper adds. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
3 tasks done
BenGSchulz
removed this pull request from stack #1443
October 22, 2026 22:04
BenGSchulz
force-pushed
the
refactor/canvas-editable-text
branch
from
October 22, 2026 22:04
f618049 to
aa5c5db
Compare
BenGSchulz
added this pull request to stack #1457
October 22, 2026 22:04
CalinaCristian
approved these changes
Oct 24, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The canvas
EditableTextduplicated the one now in apollo-wind. It becomes a thin wrapper that adds React Flow'snodragandnowheelclasses, so dragging or scrolling over the text leaves the canvas alone (MST-16146).NodePropertyPanelneeds no changes.truncationTooltipinstead ofCanvasTooltip, with the same 700ms delay.Decisions worth a look
nowheelnow also applies to the read trigger and static text, which before only the editor had.CanvasTooltipstyled its own.Test plan
nodragStack
🤖 Generated with Claude Code