Skip to content

refactor(apollo-react): build the canvas EditableText on apollo-wind's [MST-16146] - #1442

Open
BenGSchulz wants to merge 1 commit into
feat/editable-textfrom
refactor/canvas-editable-text
Open

BenGSchulz wants to merge 1 commit into
feat/editable-textfrom
refactor/canvas-editable-text

Conversation

@BenGSchulz

@BenGSchulz BenGSchulz commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Summary

The canvas EditableText duplicated the one now in apollo-wind. It becomes a thin wrapper that adds React Flow's nodrag and nowheel classes, so dragging or scrolling over the text leaves the canvas alone (MST-16146).

  • Its name, export and props are unchanged, so NodePropertyPanel needs no changes.
  • The overflow tooltip comes from apollo-wind's truncationTooltip instead of CanvasTooltip, with the same 700ms delay.
  • The behaviour tests moved to apollo-wind with the component. The canvas tests cover what the wrapper adds.

Decisions worth a look

  • nowheel now also applies to the read trigger and static text, which before only the editor had.
  • The tooltip's look comes from apollo-wind: its content wraps at 320px, where CanvasTooltip styled its own.
  • Both Editable Text stories remain, under apollo-wind Core and canvas Panels. They overlap, so the canvas one could be trimmed.

Test plan

  • apollo-react: canvas suite passes (3,634 tests), typecheck clean against the built apollo-wind, Biome clean
  • Storybook (app): a truncated node name in the canvas Editable Text playground shows its full text on hover, and the trigger keeps nodrag

Stack

  1. fix(apollo-wind): build the field header actions on the 3xs Button [MST-16146] #1456: Field header actions on the 3xs Button
  2. feat(apollo-wind): built-in variable and prompt modes in QuickFormField [MST-16146] #1440: Built-in variable and prompt modes
  3. feat(apollo-wind): EditableText, and an editable label in QuickFormField [MST-16146] #1441: EditableText and an editable label
  4. refactor(apollo-react): build the canvas EditableText on apollo-wind's [MST-16146] #1442: Canvas EditableText on apollo-wind's ← this PR

🤖 Generated with Claude Code

@github-actions
github-actions Bot temporarily deployed to preview/apollo-landing October 21, 2026 23:52 Destroyed
@github-actions
github-actions Bot temporarily deployed to preview/apollo-design October 21, 2026 23:52 Destroyed
@github-actions
github-actions Bot temporarily deployed to preview/apollo-docs October 21, 2026 23:52 Destroyed
@github-actions
github-actions Bot temporarily deployed to preview/apollo-vertex October 21, 2026 23:52 Destroyed
@BenGSchulz
BenGSchulz added this pull request to stack #1443 October 21, 2026 23:52
@github-actions

Copy link
Copy Markdown
Contributor

Dependency License Review

  • ✅ 1957 package(s) scanned
  • ✅ No license issues found
  • ⚠️ 2 package(s) excluded (see details below)
License distribution
License Packages
MIT 1721
ISC 91
Apache-2.0 57
BSD-3-Clause 28
BSD-2-Clause 23
BlueOak-1.0.0 8
MPL-2.0 4
CC0-1.0 4
MIT-0 3
MIT OR Apache-2.0 2
(MIT OR Apache-2.0) 2
Unlicense 2
LGPL-3.0-or-later 1
Python-2.0 1
CC-BY-4.0 1
(MPL-2.0 OR Apache-2.0) 1
Unknown 1
Artistic-2.0 1
(WTFPL OR MIT) 1
(BSD-2-Clause OR MIT OR Apache-2.0) 1
CC-BY-3.0 1
0BSD 1
(MIT OR CC0-1.0) 1
MIT AND ISC 1
Excluded packages
Package Version License Reason
@img/sharp-libvips-linux-x64 1.3.4 LGPL-3.0-or-later LGPL pre-built binary, not linked
khroma 2.1.0 Unknown MIT per GitHub repo, missing license field in package.json

@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

📊 Coverage + size by package

Per-package coverage and bundle size on this PR. New-line coverage = of the source lines this PR adds or changes, the % hit by tests.

Package Coverage New-line coverage Packed (gzip) Unpacked vs main
@uipath/apollo-core — — 42.02 MB 50.17 MB ±0
@uipath/apollo-react 58.0% 100.0% (1/1) 8.14 MB 32.14 MB −2.7 KB
@uipath/apollo-ui-icons — — 2.86 MB 6.97 MB ±0
@uipath/apollo-vertex — — — — —
@uipath/apollo-wind — — 816.4 KB 4.70 MB +5.7 KB
@uipath/ap-chat 85.8% — 40.42 MB 45.71 MB −603 B

"Coverage" is each package's own coverage.include scope (e.g. apollo-core instruments only scripts/). "Packed"/"Unpacked" come from npm pack --dry-run and only cover built packages — "—" means not measured this run (package not affected / not built). "vs main" is the packed (gzipped) delta against the last successful main build (the package-sizes artifact from the Release workflow); "—" there means no main baseline was available this run. The baseline is main's latest build, not this PR's exact merge-base, so it includes any drift since the branch diverged. Packages with no vitest config are omitted.

@BenGSchulz
BenGSchulz marked this pull request as ready for review October 22, 2026 01:20
Copilot AI balanced review requested due to automatic review settings October 22, 2026 01:20

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions github-actions Bot added the size:XL 500-999 changed lines. label Oct 22, 2026
@BenGSchulz
BenGSchulz force-pushed the refactor/canvas-editable-text branch from ffa426f to f618049 Compare October 22, 2026 18:56
Copilot AI balanced review requested due to automatic review settings October 22, 2026 18:56

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions
github-actions Bot temporarily deployed to preview/apollo-landing October 22, 2026 18:56 Destroyed
@github-actions
github-actions Bot temporarily deployed to preview/apollo-vertex October 22, 2026 18:56 Destroyed
@github-actions
github-actions Bot temporarily deployed to preview/apollo-design October 22, 2026 18:56 Destroyed
@github-actions
github-actions Bot temporarily deployed to preview/apollo-docs October 22, 2026 18:56 Destroyed
…s [MST-16146]

The canvas EditableText duplicated the click-to-edit text now in
apollo-wind. It becomes a thin wrapper that adds React Flow's `nodrag`
and `nowheel` classes, so dragging or scrolling over the text leaves
the canvas alone. Its name, export and props are unchanged.

The overflow tooltip now comes from apollo-wind's `truncationTooltip`
instead of CanvasTooltip, with the same 700ms delay. The read trigger
and static text also gain `nowheel`, which only the editor had before.

The behaviour tests moved to apollo-wind with the component; the canvas
tests cover what the wrapper adds.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch was successfully deployed

4 active deployments
preview/apollo-vertex — aa5c5db3 Deployed Oct 22, 2026 by github-actions[bot]
preview/apollo-landing — aa5c5db3 Deployed Oct 22, 2026 by github-actions[bot]
preview/apollo-design — aa5c5db3 Deployed Oct 22, 2026 by github-actions[bot]
preview/apollo-docs — aa5c5db3 Deployed Oct 22, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg:apollo-react size:XL 500-999 changed lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants