Skip to content

fix(apollo-vertex): use tabular, right-aligned figures in numeric columns #1388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ruudandriessen merged 1 commit into from
Oct 16, 2026
Merged

fix(apollo-vertex): use tabular, right-aligned figures in numeric columns #1388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/apollo-vertex/content/docs/components/table.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,14 @@ export const invoices = [
<TableCell className="font-medium">{invoice.invoice}</TableCell>
<TableCell>{invoice.status}</TableCell>
<TableCell>{invoice.method}</TableCell>
<TableCell className="text-right">{invoice.amount}</TableCell>
<TableCell className="text-right tabular-nums">{invoice.amount}</TableCell>
</TableRow>
))}
</TableBody>
<TableFooter>
<TableRow>
<TableCell colSpan={3}>Total</TableCell>
<TableCell className="text-right">$1,750.00</TableCell>
<TableCell className="text-right tabular-nums">$1,750.00</TableCell>
</TableRow>
</TableFooter>
</Table>
Expand Down
6 changes: 4 additions & 2 deletions apps/apollo-vertex/templates/dashboard/DashboardCards.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ export function InvoiceTable() {
<TableRow>
<TableHead>{t("invoice")}</TableHead>
<TableHead>{t("vendor")}</TableHead>
<TableHead>{t("amount")}</TableHead>
<TableHead className="text-right">{t("amount")}</TableHead>
<TableHead>{t("status")}</TableHead>
<TableHead>{t("date")}</TableHead>
</TableRow>
Expand All @@ -176,7 +176,9 @@ export function InvoiceTable() {
<TableRow key={inv.id}>
<TableCell className="font-medium">{inv.id}</TableCell>
<TableCell>{inv.vendor}</TableCell>
<TableCell>{inv.amount}</TableCell>
<TableCell className="text-right tabular-nums">
{inv.amount}
</TableCell>
<TableCell>
<Badge
variant={statusVariant[inv.status]}
Expand Down
6 changes: 4 additions & 2 deletions apps/apollo-vertex/templates/shell/InvoiceDashboard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ export function InvoiceDashboard() {
<TableRow>
<TableHead>Invoice</TableHead>
<TableHead>Vendor</TableHead>
<TableHead>Amount</TableHead>
<TableHead className="text-right">Amount</TableHead>
<TableHead>Status</TableHead>
<TableHead>Date</TableHead>
</TableRow>
Expand All @@ -176,7 +176,9 @@ export function InvoiceDashboard() {
>
<TableCell className="font-medium">{inv.id}</TableCell>
<TableCell>{inv.vendor}</TableCell>
<TableCell>{inv.amount}</TableCell>
<TableCell className="text-right tabular-nums">
{inv.amount}
</TableCell>
<TableCell>
<Badge variant={statusVariant[inv.status]}>
{inv.status}
Expand Down
6 changes: 4 additions & 2 deletions apps/apollo-vertex/templates/shell/LoanQcDashboard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ export function LoanQcDashboard() {
<TableRow>
<TableHead>Loan ID</TableHead>
<TableHead>Borrower</TableHead>
<TableHead>Amount</TableHead>
<TableHead className="text-right">Amount</TableHead>
<TableHead>Type</TableHead>
<TableHead>Status</TableHead>
<TableHead>Date</TableHead>
Expand All @@ -196,7 +196,9 @@ export function LoanQcDashboard() {
<TableRow key={loan.id}>
<TableCell className="font-medium">{loan.id}</TableCell>
<TableCell>{loan.borrower}</TableCell>
<TableCell>{loan.amount}</TableCell>
<TableCell className="text-right tabular-nums">
{loan.amount}
</TableCell>
<TableCell className="text-muted-foreground">
{loan.type}
</TableCell>
Expand Down
6 changes: 5 additions & 1 deletion packages/apollo-vertex/registry/table-chart/table-chart-view.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,11 @@ export function TableChart({
const value = getValue<PrimitiveValue>();
return (
<div
className={column.align === "right" ? "text-right" : "text-left"}
className={
column.align === "right"
? "text-right tabular-nums"
: "text-left"
}
>
{column.format(value)}
</div>
Expand Down
Loading