Repository navigation
fix(apollo-vertex): use tabular, right-aligned figures in numeric columns - #1388
Conversation
…umns TableChart already right-aligns columns whose align is "right" (the adapter derives this from numeric, currency, percentage, duration and datetime field types). Those cells now also use tabular-nums so digits line up across rows. Table is a generic shadcn primitive with no numeric or align API, so it is left unchanged. The docs example and the dashboard templates now set text-right tabular-nums on their amount columns, and right-align the matching headers.
There was a problem hiding this comment.
🔵 Needs a closer look
No code defects were identified, but the explicitly requested designer review of dashboard amount-column alignment remains outstanding.
0 open findings
What changed in this PR
Improves numeric-column readability in Apollo Vertex tables without changing the generic table primitive.
Changes:
- Adds tabular figures to right-aligned table-chart cells.
- Right-aligns dashboard amount headers and cells, with tabular figures.
- Updates documentation amounts and totals to use tabular figures.
| File | Description |
|---|---|
| packages/apollo-vertex/registry/table-chart/table-chart-view.tsx | Adds tabular figures to right-aligned cells. |
| apps/apollo-vertex/templates/shell/LoanQcDashboard.tsx | Aligns loan amounts and their header. |
| apps/apollo-vertex/templates/shell/InvoiceDashboard.tsx | Aligns invoice amounts and their header. |
| apps/apollo-vertex/templates/dashboard/DashboardCards.tsx | Applies consistent invoice amount styling. |
| apps/apollo-vertex/content/docs/components/table.mdx | Adds tabular figures to example amounts and total. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Dependency License Review
License distribution
Excluded packages
|
📊 Coverage + size by packagePer-package coverage and bundle size on this PR. New-line coverage = of the source lines this PR adds or changes, the % hit by tests.
"Coverage" is each package's own |
Storybook visual diff✅ No stories are affected by this PR's changes; nothing to compare. Logs Updated (PT): Oct 16, 2026, 04:53:06 AM |
Summary
Fixes the lintapple finding "Numeric columns: tabular figures and alignment" for
tableandtable-chart.align: "right"now render cells withtext-right tabular-nums. The adapter already setsalignfrom the field type throughdataTypeAlignment(numeric, currency, percentage, duration and datetime map to right), so numeric columns get tabular figures automatically. Headers were already right-aligned throughjustify-end.InvoiceDashboard,LoanQcDashboard,DashboardCards) now usetext-right tabular-numson amount cells andtext-righton their headers.Notes for review
align: "right"columns, so I could not reproduce the "start-aligned" part of the finding. This PR only adds the tabular figures there. If the finding came from a consumer passingalign: "left"for numeric data, that is a usage issue and not a component bug..changesetdirectory.Verification
pnpm lint(oxlint type-aware) andpnpm typecheckinpackages/apollo-vertexandapps/apollo-vertexpnpm testinpackages/apollo-vertex