Skip to content

fix(apollo-vertex): use tabular, right-aligned figures in numeric columns - #1388

Merged
ruudandriessen merged 1 commit into
mainfrom
fix/vertex-numeric-columns
Oct 16, 2026
Merged

ruudandriessen merged 1 commit into
mainfrom
fix/vertex-numeric-columns

Conversation

@ruudandriessen

Copy link
Copy Markdown
Collaborator

Summary

Fixes the lintapple finding "Numeric columns: tabular figures and alignment" for table and table-chart.

  • table-chart: columns with align: "right" now render cells with text-right tabular-nums. The adapter already sets align from the field type through dataTypeAlignment (numeric, currency, percentage, duration and datetime map to right), so numeric columns get tabular figures automatically. Headers were already right-aligned through justify-end.
  • table: this is a generic shadcn primitive with no numeric or align API, so the component is unchanged. The docs example (amount column and footer total) and the dashboard templates (InvoiceDashboard, LoanQcDashboard, DashboardCards) now use text-right tabular-nums on amount cells and text-right on their headers.

Notes for review

  • This is a design call and needs a designer to look at it, mainly the right-aligned amount column in the middle of the dashboard templates, between Vendor and Status.
  • In the source, table-chart cells were already right-aligned for align: "right" columns, so I could not reproduce the "start-aligned" part of the finding. This PR only adds the tabular figures there. If the finding came from a consumer passing align: "left" for numeric data, that is a usage issue and not a component bug.
  • No changeset: the repo has no .changeset directory.

Verification

  • pnpm lint (oxlint type-aware) and pnpm typecheck in packages/apollo-vertex and apps/apollo-vertex
  • pnpm test in packages/apollo-vertex

…umns

TableChart already right-aligns columns whose align is "right" (the
adapter derives this from numeric, currency, percentage, duration and
datetime field types). Those cells now also use tabular-nums so digits
line up across rows.

Table is a generic shadcn primitive with no numeric or align API, so it
is left unchanged. The docs example and the dashboard templates now set
text-right tabular-nums on their amount columns, and right-align the
matching headers.
@ruudandriessen
ruudandriessen requested a review from a team as a code owner October 16, 2026 11:42
@ruudandriessen
ruudandriessen requested review from 0xr3ngar and angeloaltamiranom and a balanced review from Copilot October 16, 2026 11:42
@github-actions github-actions Bot added the size:S 10-29 changed lines. label Oct 16, 2026
@github-actions
github-actions Bot temporarily deployed to preview/apollo-landing October 16, 2026 11:43 Destroyed
@github-actions
github-actions Bot temporarily deployed to preview/apollo-docs October 16, 2026 11:44 Destroyed
@github-actions
github-actions Bot temporarily deployed to preview/apollo-design October 16, 2026 11:44 Destroyed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

No code defects were identified, but the explicitly requested designer review of dashboard amount-column alignment remains outstanding.

0 open findings

What changed in this PR

Improves numeric-column readability in Apollo Vertex tables without changing the generic table primitive.

Changes:

  • Adds tabular figures to right-aligned table-chart cells.
  • Right-aligns dashboard amount headers and cells, with tabular figures.
  • Updates documentation amounts and totals to use tabular figures.
File Description
packages/​apollo-vertex/​registry/​table-chart/​table-chart-view.tsx Adds tabular figures to right-aligned cells.
apps/​apollo-vertex/​templates/​shell/​LoanQcDashboard.tsx Aligns loan amounts and their header.
apps/​apollo-vertex/​templates/​shell/​InvoiceDashboard.tsx Aligns invoice amounts and their header.
apps/​apollo-vertex/​templates/​dashboard/​DashboardCards.tsx Applies consistent invoice amount styling.
apps/​apollo-vertex/​content/​docs/​components/​table.mdx Adds tabular figures to example amounts and total.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@github-actions
github-actions Bot temporarily deployed to preview/apollo-vertex October 16, 2026 11:44 Destroyed
@github-actions

Copy link
Copy Markdown
Contributor

Dependency License Review

  • ✅ 1947 package(s) scanned
  • ✅ No license issues found
  • ⚠️ 2 package(s) excluded (see details below)
License distribution
License Packages
MIT 1713
ISC 91
Apache-2.0 56
BSD-3-Clause 28
BSD-2-Clause 23
BlueOak-1.0.0 8
MPL-2.0 4
MIT-0 3
CC0-1.0 3
MIT OR Apache-2.0 2
(MIT OR Apache-2.0) 2
Unlicense 2
LGPL-3.0-or-later 1
Python-2.0 1
CC-BY-4.0 1
(MPL-2.0 OR Apache-2.0) 1
Unknown 1
Artistic-2.0 1
(WTFPL OR MIT) 1
(BSD-2-Clause OR MIT OR Apache-2.0) 1
CC-BY-3.0 1
0BSD 1
(MIT OR CC0-1.0) 1
MIT AND ISC 1
Excluded packages
Package Version License Reason
@img/sharp-libvips-linux-x64 1.3.4 LGPL-3.0-or-later LGPL pre-built binary, not linked
khroma 2.1.0 Unknown MIT per GitHub repo, missing license field in package.json

@github-actions

Copy link
Copy Markdown
Contributor

📊 Coverage + size by package

Per-package coverage and bundle size on this PR. New-line coverage = of the source lines this PR adds or changes, the % hit by tests.

Package Coverage New-line coverage Packed (gzip) Unpacked vs main
@uipath/apollo-core — — — — —
@uipath/apollo-react — — — — —
@uipath/apollo-ui-icons — — — — —
@uipath/apollo-vertex 68.8% — (5 untracked) 325.9 KB 1.84 MB +10 B
@uipath/apollo-wind — — — — —
@uipath/ap-chat — — — — —

"Coverage" is each package's own coverage.include scope (e.g. apollo-core instruments only scripts/). "Packed"/"Unpacked" come from npm pack --dry-run and only cover built packages — "—" means not measured this run (package not affected / not built). "vs main" is the packed (gzipped) delta against the last successful main build (the package-sizes artifact from the Release workflow); "—" there means no main baseline was available this run. The baseline is main's latest build, not this PR's exact merge-base, so it includes any drift since the branch diverged. Packages with no vitest config are omitted.

@github-actions

Copy link
Copy Markdown
Contributor

Storybook visual diff

✅ No stories are affected by this PR's changes; nothing to compare. Logs

Updated (PT): Oct 16, 2026, 04:53:06 AM

@ruudandriessen
ruudandriessen merged commit dd561ff into main Oct 16, 2026
44 of 45 checks passed
@ruudandriessen
ruudandriessen deleted the fix/vertex-numeric-columns branch October 16, 2026 11:53

This branch was successfully deployed

No deployments
preview/apollo-vertex — f2966431 Deployed Oct 16, 2026 by github-actions[bot]
preview/apollo-design — f2966431 Deployed Oct 16, 2026 by github-actions[bot]
preview/apollo-docs — f2966431 Deployed Oct 16, 2026 by github-actions[bot]
preview/apollo-landing — f2966431 Deployed Oct 16, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants