Skip to content

Refactor Teams authorization to use Laminas ACL assertions #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexdryden merged 33 commits into from
Nov 27, 2025
Merged

Refactor Teams authorization to use Laminas ACL assertions #190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
02516e9
Initial plan
Copilot Nov 24, 2025
867fd1d
Create InTeamAssertion class and refactor Module.php to use it
Copilot Nov 24, 2025
fc91fd0
Update event listeners to use ACL system with assertion
Copilot Nov 24, 2025
fb6288f
Address code review feedback: fix namespaces, remove messenger, fix m…
Copilot Nov 24, 2025
d033d0d
Fix string escaping and comment in getResourceClass method
Copilot Nov 24, 2025
0bfcab2
Fix duplicate TeamRole condition and incorrect string comparison logic
Copilot Nov 24, 2025
60712ef
fix: remove permissions unless granted by team
alexdryden Nov 25, 2025
1d660ec
refactor: clean up funtions that can now be contolled via ACL
alexdryden Nov 25, 2025
6e7e91c
fix: not get class from ResourceInterface
alexdryden Nov 25, 2025
0dcd49d
add SiteAdapter to list of adapters
alexdryden Nov 25, 2025
835424d
fix: normalize GenericResource class test
alexdryden Nov 25, 2025
814f805
add acl handling for adapters that display some form buttons
alexdryden Nov 25, 2025
a330545
ensure all roles but the global admin are added
alexdryden Nov 25, 2025
da2cfc2
refactor: rename acl asertion for team role authority
alexdryden Nov 25, 2025
891859c
fix: cleanup
alexdryden Nov 25, 2025
d001086
Code quality improvements: fix formatting, rename factory, add docume…
Copilot Nov 25, 2025
f391b97
Improve documentation for getResourceClass method
Copilot Nov 25, 2025
07641a5
Refactor getResourceClass to use ResourceInterface::getResourceId()
Copilot Nov 25, 2025
9864ae5
Add GenericResource check and fix type hints for isResourceInTeam
Copilot Nov 25, 2025
4330734
Import GenericResource and improve type safety in isResourceInTeam
Copilot Nov 25, 2025
934f31a
Final cleanup: import GenericResource, improve documentation and type…
Copilot Nov 25, 2025
ffcf350
Improve documentation clarity for GenericResource handling and type e…
Copilot Nov 25, 2025
19600af
Add EntityInterface type guard for type safety
Copilot Nov 25, 2025
fdb74eb
add documentation
alexdryden Nov 25, 2025
4463b36
Move type guards into isResourceInTeam for better encapsulation
Copilot Nov 25, 2025
166f3f3
Add explicit mixed type declaration to isResourceInTeam parameter
Copilot Nov 25, 2025
754e8d3
fix: add site adapters to permissions that should pass site gate
alexdryden Nov 25, 2025
e4b5e75
Merge remote-tracking branch 'refs/remotes/origin/copilot/refactor-te…
alexdryden Nov 25, 2025
27c37c9
Use public constants for resource domains to ensure Module.php and as…
Copilot Nov 25, 2025
57bbb59
Add ITEM_ENTITIES constant for clearer separation in isResourceInTeam
Copilot Nov 25, 2025
1cc75a9
Use separate entity/adapter constants to eliminate fragile string fil…
Copilot Nov 25, 2025
1f2d21c
Eliminate constant duplication by computing combined domains dynamically
Copilot Nov 25, 2025
ad97d5d
Rename ITEM constants to RESOURCE for domain clarity
Copilot Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading