Refactor Teams authorization to use Laminas ACL assertions#190

Merged

alexdryden merged 33 commits into

developfrom

copilot/refactor-teams-module-authorization

Nov 27, 2025

Commits on Nov 24, 2025

Commits on Nov 25, 2025

fix: remove permissions unless granted by team
alexdryden
committed
refactor: clean up funtions that can now be contolled via ACL
alexdryden
committed
fix: not get class from ResourceInterface
alexdryden
committed
add SiteAdapter to list of adapters
alexdryden
committed
fix: normalize GenericResource class test
alexdryden
committed
add acl handling for adapters that display some form buttons
alexdryden
committed
ensure all roles but the global admin are added
alexdryden
committed
refactor: rename acl asertion for team role authority
alexdryden
committed
fix: cleanup
alexdryden
committed
Code quality improvements: fix formatting, rename factory, add documentation

Copilot
and
alexdryden
committed
Improve documentation for getResourceClass method

Copilot
and
alexdryden
committed
Refactor getResourceClass to use ResourceInterface::getResourceId()

Copilot
and
alexdryden
committed
Add GenericResource check and fix type hints for isResourceInTeam

Copilot
and
alexdryden
committed
Import GenericResource and improve type safety in isResourceInTeam

Copilot
and
alexdryden
committed
Final cleanup: import GenericResource, improve documentation and type safety

Copilot
and
alexdryden
committed
Improve documentation clarity for GenericResource handling and type expectations

Copilot
and
alexdryden
committed
Add EntityInterface type guard for type safety

Copilot
and
alexdryden
committed
add documentation
alexdryden
committed
Move type guards into isResourceInTeam for better encapsulation

Copilot
and
alexdryden
committed
Add explicit mixed type declaration to isResourceInTeam parameter

Copilot
and
alexdryden
committed
fix: add site adapters to permissions that should pass site gate
alexdryden
committed
Merge remote-tracking branch 'refs/remotes/origin/copilot/refactor-teams-module-authorization' into copilot/refactor-teams-module-authorization
alexdryden
committed
Use public constants for resource domains to ensure Module.php and assertion stay synchronized

Copilot
and
alexdryden
committed
Add ITEM_ENTITIES constant for clearer separation in isResourceInTeam

Copilot
and
alexdryden
committed
Use separate entity/adapter constants to eliminate fragile string filtering

Copilot
and
alexdryden
committed
Eliminate constant duplication by computing combined domains dynamically

Copilot
and
alexdryden
committed
Rename ITEM constants to RESOURCE for domain clarity

Copilot
and
alexdryden
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor Teams authorization to use Laminas ACL assertions#190

Refactor Teams authorization to use Laminas ACL assertions#190
alexdryden merged 33 commits into
developfrom
copilot/refactor-teams-module-authorization

Commits on Nov 24, 2025

Initial plan

Create InTeamAssertion class and refactor Module.php to use it

Update event listeners to use ACL system with assertion

Address code review feedback: fix namespaces, remove messenger, fix magic numbers

Fix string escaping and comment in getResourceClass method

Fix duplicate TeamRole condition and incorrect string comparison logic

Commits on Nov 25, 2025

fix: remove permissions unless granted by team

refactor: clean up funtions that can now be contolled via ACL

fix: not get class from ResourceInterface

add SiteAdapter to list of adapters

fix: normalize GenericResource class test

add acl handling for adapters that display some form buttons

ensure all roles but the global admin are added

refactor: rename acl asertion for team role authority

fix: cleanup

Code quality improvements: fix formatting, rename factory, add documentation

Improve documentation for getResourceClass method

Refactor getResourceClass to use ResourceInterface::getResourceId()

Add GenericResource check and fix type hints for isResourceInTeam

Import GenericResource and improve type safety in isResourceInTeam

Final cleanup: import GenericResource, improve documentation and type safety

Improve documentation clarity for GenericResource handling and type expectations

Add EntityInterface type guard for type safety

add documentation

Move type guards into isResourceInTeam for better encapsulation

Add explicit mixed type declaration to isResourceInTeam parameter

fix: add site adapters to permissions that should pass site gate

Merge remote-tracking branch 'refs/remotes/origin/copilot/refactor-teams-module-authorization' into copilot/refactor-teams-module-authorization

Use public constants for resource domains to ensure Module.php and assertion stay synchronized

Add ITEM_ENTITIES constant for clearer separation in isResourceInTeam

Use separate entity/adapter constants to eliminate fragile string filtering

Eliminate constant duplication by computing combined domains dynamically

Rename ITEM constants to RESOURCE for domain clarity