commit cbs panel code and merge latest old arm code - #15
Merged
Conversation
Contributor
|
I'm not familiar with the old/new code, but if we are updating the code and want to maintain cpp, should we change the ino and c files to be cpp? |
douglasichen
approved these changes
Oct 26, 2025
|
|
||
| // general parameters | ||
| #define NUM_AXES 6 | ||
| #define NUM_AXES 7 |
Contributor
There was a problem hiding this comment.
is the num axes increase intentional?
Contributor
Author
There was a problem hiding this comment.
yup, one of the axes is used for the end effector
Contributor
Author
that would be good, I'd like to move away from arduino. i think platform IO would be a good choice but im looking into it. it depends on our hardware, I'd like to get away with just makefiles |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forgot about my old branch before merging my "houskeeping" PR. After that pr, merge conficts were really nasty between rowzaw/main (where the latest code is) and main.
I just grabbed the arm source files and pasted them into this PR.