Repository navigation
Fix DeepScan issues - #1390
Merged
Merged
Fix DeepScan issues#1390
Conversation
- purge: skip channels missing from cache instead of dereferencing undefined - sheesh: null-safe member.id in passjoint - report: drop redundant always-true role_moderator check - rpg/profile/levels: remove dead variable assignments - matrix: fix always-true calc_nasal condition and NaN checks, drop await on handler - irc archive: remove unused imports/requires - tests for the purge and sheesh null cases Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the open DeepScan findings.
d.purgeskips channels missing from cache;d.sheeshpassjoint usesmember?.id.d.reportredundant moderator check removed;m.calc_nasalconditionfunc === 'substance' || 'solvent'fixed, and!== nullreplaced by!Number.isNaN(non-numeric input now shows usage instead of printing NaN).d.rpg,d.profile,d.levelsdead assignments removed.matrix.ts, and the IRC archive files.Tests added for the purge missing-channel and sheesh null-member cases.
Verification
tsc --noEmitclean; affected Vitest files pass (162 passed). No command definitions changed.🤖 Generated with Claude Code