Repository navigation
Fix remaining DeepScan issues in legacy events and archived commands - #1394
Merged
Merged
Conversation
…rror - Move `export default X` below the `export const X` declaration in the legacy event handlers - Make the d.radio Ready callback async so its await is valid Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
- Remove unused imports and unused `F` declarations - u_profile: drop unused actor/target variables - tripsat: drop always-true date check, test targetRoles.length Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #1390, which merged before these last fixes were pushed.
src/discord/events/legacy/,export default X;now comes after theexport const Xdeclaration.src/discord/commands/archive/d.radio.tsReadycallback is nowasyncso itsawaitis valid.tripsat.ts,u_profile.ts,u.underban.ts,invite.ts,removeDuplicateRoles.ts,d.whois.ts. Intripsat.tsthe always-trueif (targetLastHelpedDate)wrapper is removed andif (targetRoles)is nowtargetRoles.length > 0.Verification
All changed files parse without syntax errors and
git diff --checkis clean. These files are in the archive/legacy folders, which lint,tscand Vitest exclude, so no tests apply; DeepScan will re-scan on this PR. No command definitions changed.🤖 Generated with Claude Code