CLIENTS: EventParticipantSecretV2Client - Redact Secret Hash On Returns - #726
Merged
cjdutoit merged 4 commits intoJul 18, 2026
Conversation
github-actions
Bot
added
the
CLIENTS
cjdutoit
deleted the
users/cjdutoit/mediumfix-eventparticipantsecretv2client-redact-secret
branch
July 18, 2026 06:16
This was referenced Jul 18, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security review finding #13. The V2 participant-secret client returned the full entity — including the stored SHA-256 hash in
Secret— on reads, so the hash tended to reach admin UIs and API payloads and widen the offline-cracking surface.The client now redacts
SecrettonullonRetrieveAll,RetrieveById,Modify, andRemove.Addstill echoes the entity (the caller already holds the plaintext it submitted; documented behaviour).Secret verification composes over the foundation
IEventParticipantSecretV2Service, not this client, so the compare is unaffected — confirmed by the secret verification unit suites and all 63 acceptance tests (submit → verify → dispatch) staying green. 3027 unit + 63 acceptance pass.Developed test-first (redaction tests red → green). Updated the affected existing unit/acceptance client tests and the client XML docs to reflect the redacted returns.
closes #725