BUGFIX: EventParticipantSecretV2Service - Override Redacted Secret From Storage On Modify - #728
Merged
cjdutoit merged 3 commits intoJul 18, 2026
Conversation
cjdutoit
deleted the
users/cjdutoit/bugfix-eventparticipantsecretv2-modify-override-secret
branch
July 18, 2026 07:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a regression introduced by the #13 secret-hash redaction (#726). Once the client redacts
Secrettonullon reads, the foundationModifyrejected it — the structural "Secret required" rule and the against-storage "must match" rule both fail on a null secret. The Operations Portal re-reads the redacted secret and passes it to Modify, so editing a secret's lifecycle (activate/deactivate, active-from/to) failed with "Unable to save the secret." — reproduced end-to-end.Fix
Modifyno longer requiresSecret, andModifyEventParticipantSecretV2Asyncoverrides the incomingSecretwith the stored value before the against-storage validation. The secret stays immutable (any supplied value is ignored), lifecycle-only edits succeed, and the must-match-storage rule passes automatically.*****for the redacted column (Admin + My Account pages); the Edit flow is unchanged.Verification
*****shown throughout.closes #727