Repository navigation
VM_CONTACT: accept the preserved workspace root in U4 - #89
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 84b23b4a07
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # A preserved root (the inventoried one) may be empty; a newly chosen root must hold data. | ||
| preserved = root == pathlib.Path(state['home']).parent.resolve() | ||
| require(root.is_dir(), 'workspace must exist and be a directory') | ||
| require(preserved or any((p.name != '.vm-mcp-home' for p in root.iterdir())), 'a changed workspace root must exist and be nonempty') |
There was a problem hiding this comment.
When the inventoried root is empty or contains only .vm-mcp-home, this new condition lets U4 stop the services and run the installer, but the mandatory U5 preservation block still unconditionally fails its workspace not empty check at line 531. Consequently, the exact upgrade scenario this change intends to support cannot complete acceptance and fails only after the deployment has already been modified; U5 needs the same preserved-root exception.
Useful? React with 👍 / 👎.
U4's workspace guard refused an upgrade whose preserved root exists but is empty. Now:
target.jsonmust also be nonempty.Docs only. Not for merge without Erin.