Repository navigation
VM_CONTACT: check d ignores root-only dirs; exit 9 points to U6 - #92
Open
erinepshovel-code wants to merge 1 commit into
Open
erinepshovel-code wants to merge 1 commit into
erinepshovel-code wants to merge 1 commit into
Conversation
Check d's vmmcp-writable find prunes directories vmmcp cannot enter (the root-only __pycache__), so their permission error no longer reads as READ-FAILED; any other find error still does. A runbook test runs the published find against a temp tree. The exit-9 note now says U4 has already stopped the units and points to U6, and a stray leading space is removed.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups to #86 on
backend/deploy/VM_CONTACT.md. Based on main faf2654, which includes #86 (85c86bd) and #89 (3d74cf1).Changes
Check d: the vmmcp-writable
findnow prunes directories vmmcp cannot enter (-type d ! -executable -prune -o -writable -print), such as the root-only/opt/vm-mcp/__pycache__. Nothing inside such a directory is reachable by vmmcp, and the directory itself isn't writable by vmmcp. Any otherfinderror still setsREAD-FAILEDand printsFAIL, for example a directory vmmcp can enter but not list.Runbook test:
test_vm_contact_runbookchecks that the guard is present, then runs the publishedfindline against a temp tree:READ-FAILED.The behaviour test is skipped when run as root.
Review P3: the exit-9 note now says U4 has already stopped the units, so the MCP path is down, and points to U6.
Review P3: removed the stray leading space before "#127 hardens the installer".
Not in this PR
vm-mcp-127-check.shisn't tracked in stack or skill-lib. Its read-only sysctl fix was made only to the operator's local copy.hmmm