Repository navigation
Repair package coverage and current-suite replay #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
34f002e
repair(packaging): include derivations and bind replay to current tests
erinepshovel-code c6be479
Count parent pytest reports once when subtests succeed
erinepshovel-code adbbc1f
fix: account for pytest subtests in replay evidence
erinepshovel-code c158e18
test: cover subtest-aware JUnit replay counts
erinepshovel-code File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| """Regression coverage for pytest subtest accounting in installed replay evidence.""" | ||
| from importlib.util import module_from_spec, spec_from_file_location | ||
| from pathlib import Path | ||
|
|
||
| import pytest | ||
|
|
||
|
|
||
| VERIFIER_PATH = Path(__file__).resolve().parents[1] / "tools" / "verify_installed.py" | ||
| SPEC = spec_from_file_location("epac_installed_junit_fixture", VERIFIER_PATH) | ||
| VERIFIER = module_from_spec(SPEC) | ||
| SPEC.loader.exec_module(VERIFIER) | ||
|
|
||
|
|
||
| def _write_xml(path, tests): | ||
| path.write_text( | ||
| f'<testsuite tests="{tests}" failures="0" errors="0" skipped="0">' | ||
| '<testcase name="a"/><testcase name="b"/></testsuite>', | ||
| encoding="utf-8", | ||
| ) | ||
|
|
||
|
|
||
| def test_junit_total_accepts_explicit_successful_subtest_count(tmp_path): | ||
| xml = tmp_path / "results.xml" | ||
| _write_xml(xml, 3) | ||
| assert VERIFIER.verify_test_evidence(xml, ["a", "b"], ["a", "b"], passed_subtests=1) == 2 | ||
|
|
||
|
|
||
| def test_junit_total_rejects_unexplained_extra_results(tmp_path): | ||
| xml = tmp_path / "results.xml" | ||
| _write_xml(xml, 3) | ||
| with pytest.raises(AssertionError, match="aggregate"): | ||
| VERIFIER.verify_test_evidence(xml, ["a", "b"], ["a", "b"], passed_subtests=0) | ||
|
|
||
|
|
||
| def test_junit_total_rejects_inflated_subtest_claim(tmp_path): | ||
| xml = tmp_path / "results.xml" | ||
| _write_xml(xml, 3) | ||
| with pytest.raises(AssertionError, match="aggregate"): | ||
| VERIFIER.verify_test_evidence(xml, ["a", "b"], ["a", "b"], passed_subtests=2) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.