chore: Consolidate Duplicated Annotation Type Definitions#1900
Open
chore: Consolidate Duplicated Annotation Type Definitions#1900
Conversation
🎩 To tophat this PR:You can add the following URL parameter to your browser to tophat this PR: |
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
3 tasks
camielvs
force-pushed
the
03-04-chore_consolidate_duplicated_annotation_type_definitions
branch
3 times, most recently
from
342cfe2 to
c220f1a
Compare
camielvs
changed the base branch from
03-04-feat_add_toggle_for_collapsing_nodes
to
graphite-base/1900
camielvs
force-pushed
the
03-04-chore_consolidate_duplicated_annotation_type_definitions
branch
from
c220f1a to
041ba7b
Compare
camielvs
force-pushed
the
graphite-base/1900
branch
from
903d602 to
18933d0
Compare
camielvs
force-pushed
the
03-04-chore_consolidate_duplicated_annotation_type_definitions
branch
2 times, most recently
from
97beba7 to
71ddb30
Compare
camielvs
force-pushed
the
03-04-chore_consolidate_duplicated_annotation_type_definitions
branch
from
71ddb30 to
0287012
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There is an
Annotationstype defined inutils/annotationsand again intypes/annotationsleading to confusion and weird typecasting.This PR consolidates it down into one
Annotationtype to match that of the Component Spec.No change to app functionality.
Related Issue and Pull requests
Type of Change
Checklist
Screenshots (if applicable)
Test Instructions
Additional Comments