Open
Conversation
🎩 To tophat this PR:You can add the following URL parameter to your browser to tophat this PR: |
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
camielvs
force-pushed
the
03-04-feat_add_toggle_for_collapsing_nodes
branch
from
5b0d62f to
7aa131f
Compare
camielvs
force-pushed
the
03-04-feat_add_toggle_for_collapsing_nodes
branch
from
7aa131f to
903d602
Compare
3 tasks
maxy-shpfy
reviewed
Mar 5, 2026
| return annotations; | ||
| } | ||
|
|
||
| const { [key]: _, ...rest } = annotations; |
maxy-shpfy
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove auto-collapsing of nodes based on
editor.position.heightand instead introduce a new annotationeditor.collapsedfor manual toggling of whether the node is collapsed.Users can now toggle collapsed state via a switch in the task configuration section. Collapsed state is no longer directly related to the values entered in
editor.position. Instead,editor.positionheight and width values will be used for the uncollapsed node state, if provided.Collapse logic & rendering is unchanged from before.
Related Issue and Pull requests
Closes https://github.com/Shopify/oasis-frontend/issues/476
Type of Change
Checklist
Screenshots (if applicable)
Test Instructions
editor.positionannotation to add a height value. confirm it does not affect collapsed state.Additional Comments