Merged
Conversation
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
a42d996 to
edba5bb
Compare
b52e6b3 to
e5b794e
Compare
3 tasks
maxy-shpfy
reviewed
Feb 26, 2026
maxy-shpfy
reviewed
Feb 26, 2026
maxy-shpfy
reviewed
Feb 26, 2026
maxy-shpfy
reviewed
Feb 26, 2026
edba5bb to
55bb986
Compare
e5b794e to
075d6c9
Compare
🎩 To tophat this PR:You can add the following URL parameter to your browser to tophat this PR: |
maxy-shpfy
reviewed
Mar 5, 2026
maxy-shpfy
reviewed
Mar 5, 2026
Collaborator
|
Is it expected, that I cant see tags in a Runs list? Screen Recording 2026-03-04 at 8.16.00 PM.mov (uploaded via Graphite) |
Collaborator
|
^ |
maxy-shpfy
reviewed
Mar 5, 2026
075d6c9 to
495c64b
Compare
374e602 to
bb23d52
Compare
495c64b to
4f569a8
Compare
Collaborator
Author
|
Tag limit of 10 should fix the issue. I also changed it so we do not submit tags if there are none. |
34230ab to
199592d
Compare
maxy-shpfy
approved these changes
Mar 5, 2026
Collaborator
Author
Merge activity
|
76d0f26 to
dd3f48e
Compare
dd3f48e to
5288e9e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
Pipeline Tags will now be submitted alongside a Run as run annotations and will be shown on the Run List and in a run's context panel, similar to the pipeline editor (but Run Tags cannot be edited or removed).
(I also did a little cleanup on
RunSectionwhile in the file)Related Issue and Pull requests
Closes https://github.com/Shopify/oasis-frontend/issues/472
Type of Change
Checklist
Screenshots (if applicable)
Test Instructions
Confirm that:
Additional Comments
The tags in the run's context panel are sourced from the pipeline component spec, not the run annotations (as might be expected). Currently the content of the two is the same at time of submission. Sourcing the tags from the run annotations requires and additional API call. hence, I chose (for now) to source them fromt he component spec. If there should be reason in the future for the two sources to diverge then we can switch it over to sourcing from the run annotations API.