Skip to content

feat: Submit Pipeline Tags on Runs#1849

Merged
camielvs merged 1 commit intomasterfrom
02-23-feat_submit_pipeline_tags_on_runs
Mar 5, 2026
Merged

feat: Submit Pipeline Tags on Runs#1849
camielvs merged 1 commit intomasterfrom
02-23-feat_submit_pipeline_tags_on_runs

Conversation

@camielvs
Copy link
Collaborator

@camielvs camielvs commented Feb 23, 2026

Description

Pipeline Tags will now be submitted alongside a Run as run annotations and will be shown on the Run List and in a run's context panel, similar to the pipeline editor (but Run Tags cannot be edited or removed).

(I also did a little cleanup on RunSection while in the file)

Related Issue and Pull requests

Closes https://github.com/Shopify/oasis-frontend/issues/472

Type of Change

  • New feature

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

image.png

image.png

Test Instructions

  • Submit a run for a pipeline that has tags

Confirm that:

  • The tags show on the run list on the homepage for that run
  • The tags show on the run's context panel

Additional Comments

The tags in the run's context panel are sourced from the pipeline component spec, not the run annotations (as might be expected). Currently the content of the two is the same at time of submission. Sourcing the tags from the run annotations requires and additional API call. hence, I chose (for now) to source them fromt he component spec. If there should be reason in the future for the two sources to diverge then we can switch it over to sourcing from the run annotations API.

Copy link
Collaborator Author

camielvs commented Feb 23, 2026

@camielvs camielvs mentioned this pull request Feb 23, 2026
3 tasks
@camielvs camielvs force-pushed the 02-23-feat_pipeline_tags branch from a42d996 to edba5bb Compare February 23, 2026 21:37
@camielvs camielvs force-pushed the 02-23-feat_submit_pipeline_tags_on_runs branch from b52e6b3 to e5b794e Compare February 23, 2026 21:37
@camielvs camielvs marked this pull request as ready for review February 23, 2026 22:01
@camielvs camielvs requested a review from a team as a code owner February 23, 2026 22:01
@camielvs camielvs force-pushed the 02-23-feat_pipeline_tags branch from edba5bb to 55bb986 Compare March 3, 2026 00:06
@camielvs camielvs force-pushed the 02-23-feat_submit_pipeline_tags_on_runs branch from e5b794e to 075d6c9 Compare March 3, 2026 00:06
@camielvs camielvs requested a review from maxy-shpfy March 3, 2026 00:06
@github-actions
Copy link

github-actions bot commented Mar 3, 2026

🎩 To tophat this PR:

You can add the following URL parameter to your browser to tophat this PR:

`?tophat_location=02-23-feat_submit_pipeline_tags_on_runs/5288e9e`

Copy link
Collaborator

Is it expected, that I cant see tags in a Runs list?

Screen Recording 2026-03-04 at 8.16.00 PM.mov (uploaded via Graphite)

Copy link
Collaborator

^
Seems that we cant push ANY values to annotations:

{
    "error_code": 500,
    "error_message": "(pymysql.err.DataError) (1406, \"Data too long for column 'value' at row 1\")\n[SQL: INSERT INTO pipeline_run_annotation (pipeline_run_id, `key`, value) VALUES (%(pipeline_run_id)s, %(key)s, %(value)s)]\n[parameters: {'pipeline_run_id': '019cbc36f07ca9b730a3', 'key': 'tags', 'value': 'Multi-Node,A,B,LongnameLongname-1,LongnameLongname-2,LongnameLongname-3,LongnameLongname-4,LongnameLongname-5,LongnameLongname-6,LongnameLongname-7,L ... (207 characters truncated) ... ngname-18,LongnameLongname-19,LongnameLongname-20,LongnameLongname-21,LongnameLongname-22,LongnameLongname-23,LongnameLongname-24,LongnameLongname-25'}]\n(Background on this error at: https://sqlalche.me/e/20/9h9h)"
}

Copy link
Collaborator

@maxy-shpfy maxy-shpfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not send request if tags are empty.

image.png

@camielvs camielvs force-pushed the 02-23-feat_submit_pipeline_tags_on_runs branch from 075d6c9 to 495c64b Compare March 5, 2026 22:03
@camielvs camielvs force-pushed the 02-23-feat_pipeline_tags branch 2 times, most recently from 374e602 to bb23d52 Compare March 5, 2026 22:06
@camielvs camielvs force-pushed the 02-23-feat_submit_pipeline_tags_on_runs branch from 495c64b to 4f569a8 Compare March 5, 2026 22:06
Copy link
Collaborator Author

camielvs commented Mar 5, 2026

Tag limit of 10 should fix the issue.

I also changed it so we do not submit tags if there are none.

@camielvs camielvs force-pushed the 02-23-feat_submit_pipeline_tags_on_runs branch 2 times, most recently from 34230ab to 199592d Compare March 5, 2026 22:22
@camielvs camielvs requested a review from maxy-shpfy March 5, 2026 22:25
Copy link
Collaborator Author

camielvs commented Mar 5, 2026

Merge activity

  • Mar 5, 10:46 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Mar 5, 11:08 PM UTC: Graphite rebased this pull request as part of a merge.
  • Mar 5, 11:21 PM UTC: Graphite couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'Linting').
  • Mar 5, 11:25 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Mar 5, 11:26 PM UTC: Graphite rebased this pull request as part of a merge.
  • Mar 5, 11:31 PM UTC: @camielvs merged this pull request with Graphite.

@camielvs camielvs changed the base branch from 02-23-feat_pipeline_tags to graphite-base/1849 March 5, 2026 22:46
@camielvs camielvs changed the base branch from graphite-base/1849 to master March 5, 2026 23:07
@camielvs camielvs force-pushed the 02-23-feat_submit_pipeline_tags_on_runs branch 2 times, most recently from 76d0f26 to dd3f48e Compare March 5, 2026 23:23
@camielvs camielvs force-pushed the 02-23-feat_submit_pipeline_tags_on_runs branch from dd3f48e to 5288e9e Compare March 5, 2026 23:25
@camielvs camielvs merged commit c4ad545 into master Mar 5, 2026
16 of 17 checks passed
@camielvs camielvs deleted the 02-23-feat_submit_pipeline_tags_on_runs branch March 5, 2026 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants