Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
camielvs
force-pushed
the
02-23-feat_pipeline_tags
branch
from
a42d996 to
edba5bb
Compare
camielvs
force-pushed
the
02-23-feat_pipeline_tags
branch
from
edba5bb to
55bb986
Compare
🎩 To tophat this PR:You can add the following URL parameter to your browser to tophat this PR: |
|
Screen Recording 2026-03-04 at 7.12.12 PM.mov (uploaded via Graphite) Idea: maybe instead of exploding the row we can show them in a Popover? |
| onClick={(e) => { | ||
| e.stopPropagation(); | ||
| setShowAllTags(!showAllTags); | ||
| }} |
There was a problem hiding this comment.
Just thinking outloud. I'm not big fan of click-entire-row behavior, and then we need to implement workarounds like stopPropagation() to avoid redirect. Miss-click is very possible for small buttons
|
|
||
| const MAX_VISIBLE_TAGS = 3; | ||
|
|
||
| export const TagList = ({ tags }: TagListProps) => { |
There was a problem hiding this comment.
This file is not in react-compiler list, but uses unstable functions
maxy-shpfy
left a comment
maxy-shpfy
left a comment
There was a problem hiding this comment.
We need to fix an error on sending "unprocessable" payload to API. Enforce limits on number of tags allowed.
2 participants
Description
Adds UX for creating, editing and removing tags on Pipelines. This is done via a new PipelineTagEditor in the context panel below the pipeline notes.
Tags can be added using the "Add Tag" button. The tag input is a free input field - users can enter any string they like in there. To encourage our users to make wise and concise choices about tag names a length limit of 20 characters has been enforced.
Once created tags will be rendered below the input section and from there can be edited by clicking on them, or removed by clicking the "x".
The list of Pipeline Tags is saved as a csv string on the component spec annotations. This is used on the pipeline list to display the first three tags within the pipeline row. More tags can be view by clicking "+n" if there are more tags to see.
Related Issue and Pull requests
Progresses https://github.com/Shopify/oasis-frontend/issues/472
Type of Change
Checklist
Screenshots (if applicable)
Test Instructions
Confirm you are able to:
Once you have added some tags go to the homepage and open the pipeline list. Confirm that:
Additional Comments
I am not attached to the specific UX of adding & editing tags in-place, or the chosen render location of tags in the pipeline row (in the centre - between Time & Run details).