Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1031
What was wrong
The shared Windows test fixture matched
S-1-5-...anywhere inwhoami /user /fo csv /nhoutput. A valid EntraS-1-12-1-...account failed withCannot identify fixture ownerbeforeicaclsran. A SID-looking username could also be mistaken for the SID field, and failed commands were not rejected by the parser.The issue was claimed before implementation. This is a separate test-infrastructure fix from #1029.
The change
test/lib/that accepts only successful command results containing one quoted, two-field CSV record. Read only the SID column and validate the complete revision-1 SID, 48-bit authority, and up to fifteen 32-bit subauthorities.icacls /setowneraction and its failure check. Production permissions and ownership logic are unchanged.Implementation:
3a6407060c237908484ae0289151e837346ee95d. Current headf2d006be908f4b7ec84522e2b30e6feb186ca59dmerges main8545d4462ab19c3de44c7f4be385afe05bf1ec42(0.5.6), preserving history. The diff against main contains only the four issue-scoped files.Validation
All test homes were temporary; no live DSH profile, real provider or account requests.
DSH_OPS_TEST_JOBS=2andDSH_OPS_OFFLINE=1were set for runner commands.node test/run.mjs fixture-owner, original parser extracted unchangednode test/run.mjs settings, 0.5.5 base + fixnode test/run.mjs fixture-owner settings, merged 0.5.6 treenpm run validate:manifest, merged treenode scripts/check-file-size.mjs --json, merged treenpm run buildandnpm run typecheckpassed on both evaluated trees. Task diff whitespace check passed. The initial test-side ACL observation usedGet-Acl, whose module could not load in this shell environment; the final test uses the .NET Directory ACL API in Windows PowerShell and still verifies the actual owner SID without logging it. No permission assertion was removed.The one skipped suite is
settings-disclosure-e2e: no staged native worker. Full native/release provisioning and the all-suitenpm run verifygate were not run and are not claimed as passed. No dependencies, version, production source or generated files were changed by this fix. Upstream changes included through the merge retain their original history.The upstream
pull_requestCI run URL/status will be recorded after this PR is created. Local results do not substitute for the required cross-platformCI requiredrun; workflow approval remains maintainer-owned if GitHub requests it.Environment
Windows x64, Node 26.13.0, repository-local locked dependencies. Original reproduced base:
58f6e2817618fae52476e8c7f1920aaeb4421c7a(0.5.5). Current tested base:8545d4462ab19c3de44c7f4be385afe05bf1ec42(0.5.6). Source contribution only; no release or installation into a daily profile.