Repository navigation
Fix coupon expiry parsing when OCR omits the end year - #565
Merged
Merged
Conversation
Szer
enabled auto-merge (squash)
October 17, 2026 23:37
Szer
disabled auto-merge
October 17, 2026 23:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When OCR truncates the expiry year in a labelled receipt validity range, the parser falls back to unrelated receipt dates. For example,
valid from 24/09/26 to 03/10can become March 10–October 21 because the receipt also includes a goods-return deadline.Infer a missing end year from the range's start date, retaining day/month order and handling December-to-January rollover. Add both affected coupons as cached image regression fixtures and coverage for complete dates, separators, punctuation, truncated trailing separators, whitespace, and month-name ranges.
Validation:
dotnet test tests/CouponHubBot.Ocr.Tests -c Release: 61 passed.No database migration or backfill is included.