Env vars config#20
Merged
Merged
Conversation
Also auto-downloading JVM
coco875
reviewed
Jul 6, 2026
| // Example: STEEL_EXTRACTOR_DISABLE_BLOCKS=1 | ||
| val immediateExtractors = mutableListOf<Extractor>() | ||
| fun addUnlessDisabled(name: String, supplier: () -> Extractor) { | ||
| if (envFlag("STEEL_EXTRACTOR_DISABLE_$name")) { |
There was a problem hiding this comment.
does by default it return true ? to have all feature enable by default (and personally also like have the possibility to enable it with cli with arg)
Author
There was a problem hiding this comment.
Yeah if the env var doesn't exist it will add it to the list so assuming you don't do anything, they all get used. And CLI is a bit trickier and might be harder with CI. Also get's annoying if you want to disable a majority of the extractors.
Author
|
Docs updated in this PR: Steel-Foundation/SteelDocs#33 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added environment variable based enabling/disabling of extractors and closing on exit. By default it will run the same as it used to, but you can add environment variables (such as STEEL_EXTRACTOR_ENABLE_CHUNK_EXTRACTION=false) to disable the chunk extraction.
Also modifed the gradle config to automatically download a JDK if there isn't one install/it's the wrong version.