Build: Port to 26.2-snapshot-6 - #137
Conversation
| //$$ | ||
| //#endif | ||
|
|
||
| //#if MC >= 1.17 && MC < 26.2 |
There was a problem hiding this comment.
question: what does this change accomplish? why can't it remain in the above elseif block?
There was a problem hiding this comment.
It's conceptually separate from the above preprocessor chain. I.e. the fact that this is < 26.2 and that the above uses a separate block for 26.2+ are merely coincidental. Note that there's no 26.2+ replacement for this method, while there is for the one above.
The above chain is for converting the int OpenGL constant to the MC type (because our constructor needs that). It changes with 26.2+ because VertexFormat.DrawMode became PrimitiveTopology.
This method is for converting from the MC type to our type (because our fromRenderLayer needs that). It is removed with 26.2+ because fromRenderLayer is removed because RenderType (aka RenderLayer) no longer exists the way it used to.
2 participants
No description provided.