Adds Config & Integration testing support#14
Merged
Conversation
raffael0
force-pushed
the
feat/config-integrationtest
branch
from
55551ad to
84c7809
Compare
- Add a new integration test that boots the ecuemulator: container via testcontainers - Inject ECUEmulator TOML config into the container at startup (with_copy_to + CONFIG_PATH) - Run FerroFlow in a scoped thread and poll NodeManager for registration progress - Stream container stdout/stderr into the test output for easier debugging - Trigger a clean shutdown at the end of the test via Event::Shutdown
raffael0
force-pushed
the
feat/config-integrationtest
branch
from
84c7809 to
d6aadaa
Compare
raffael0
force-pushed
the
feat/config-integrationtest
branch
from
bdf06b3 to
809f898
Compare
miDeb
approved these changes
Apr 26, 2026
raffael0
force-pushed
the
feat/config-integrationtest
branch
from
0eb959c to
3e3316b
Compare
raffael0
force-pushed
the
feat/config-integrationtest
branch
from
3e3316b to
940bc7a
Compare
previously this was done asynchronously in the can send thread itself, potentially causing a race condition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces end-to-end integration test coverage for running FerroFlow against the ECUEmulator.
I've also added support for filtering the event_dispatcher events. For every
subscribecall one has to provide a list of EventKinds of the events which it should be triggered by. Also I added Event::Shutdown subscriptions for all threads for a graceful shutdown of the system.To create the vcan interfaces I had to add a custom
ipwrapper which we can give specific networking capabilities to. The idea is that the developer builds this once, places it in their Path and then the tests can be run automatically. Kind of hacky but it works. Otherwise all integration tests would need to be run with sudoRelated: SpaceTeam/ECUEmulator#17
closes: #3 #5
Note that i'll change the ecuemulator docker container once the other PR is merged