Conversation
raffael0
reviewed
May 5, 2026
Supports specifying: - a unique name for fields - a slope + offset conversion for a "mapped value" - a range-based conversion for a "logical value", that also includes a color code for the frontend The NodeManager now supports reading raw, mapped, and logical values by mapping name, requesting mapped fields from nodes, and writing mapped parameter values back as raw CAN values.
- load mappings from a directory - change mapping to be grouped by node - simplify some code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supports specifying:
NodeManager now supports reading raw, mapped, and logical values by mapping name, requesting mapped fields from nodes, and writing mapped parameter values back as raw CAN values.
I also added some validation rules for the mapping.
Depends on #14 because I read the path to the mapping from the config.
Please take a look at tests/mapping/example1.toml to see how a mapping file would look like. There are two ways to specify a mapping in there, which are only syntactically different, as toml has multiple ways to specify nested tables (=objects in json). The second example uses inline tables to a greater extent, and of course there are even more syntactically correct ways to write the same thing in toml.
I'll open this as a draft until we agree on the format of the mapping.