Repository navigation
fix: keep assembled object bases and optional method calls out of the dead-branch proof - #467
Merged
Merged
Conversation
… dead-branch proof
…es with the assembled-base and optional-call fixes
This was referenced Nov 20, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the two findings in review/r6-ox2c.md (#455's dead-branch proof through assembled objects).
const m = {k: x}; m.k = "y"; const v = m) is no longer read through its literal: it is dropped from the plain and optimistic object views, and in the write check a plain view of a symbol is no longer replaced by the assembled view, whose exemptions skip the key writes.deletechecks on such objects moved tovisit_call_expressionand friends, sov.f?.(),v["f"]?.()and(v.f)?.()count as method calls. The other visitors in control_flow_object fail closed on chain calls already.55 rows (cfo-r6-*) in obfuscator_sweep_rows.rs, both lanes vs node.
Checks against main 60df548: full obfuscator.io sweep identical per case (0 changes in either lane, all 39 lanes #455 gained kept; one case skipped in one run because node timed out on the obfuscated input, outputs identical), Krunker outputs byte-identical in both lanes, obfuscator BASELINEs unchanged, local untwist-ci green (two unrelated Firefox e2e flakes passed on rerun). Rebased on #464; crate tests rerun. Wasm baseline raised to the measured size.