Skip to content

fix: keep assembled object bases and optional method calls out of the dead-branch proof - #467

Merged
Sorte1 merged 2 commits into
mainfrom
fix/ox2-c2
Nov 20, 2026
Merged

Sorte1 merged 2 commits into
mainfrom
fix/ox2-c2

Conversation

@Sorte1

@Sorte1 Sorte1 commented Nov 20, 2026

Copy link
Copy Markdown
Owner

Fixes the two findings in review/r6-ox2c.md (#455's dead-branch proof through assembled objects).

  • F1: an object that is the base of a key-by-key run (const m = {k: x}; m.k = "y"; const v = m) is no longer read through its literal: it is dropped from the plain and optimistic object views, and in the write check a plain view of a symbol is no longer replaced by the assembled view, whose exemptions skip the key writes.
  • F2: the method-call, tagged-template and delete checks on such objects moved to visit_call_expression and friends, so v.f?.(), v["f"]?.() and (v.f)?.() count as method calls. The other visitors in control_flow_object fail closed on chain calls already.

55 rows (cfo-r6-*) in obfuscator_sweep_rows.rs, both lanes vs node.

Checks against main 60df548: full obfuscator.io sweep identical per case (0 changes in either lane, all 39 lanes #455 gained kept; one case skipped in one run because node timed out on the obfuscated input, outputs identical), Krunker outputs byte-identical in both lanes, obfuscator BASELINEs unchanged, local untwist-ci green (two unrelated Firefox e2e flakes passed on rerun). Rebased on #464; crate tests rerun. Wasm baseline raised to the measured size.

This branch was successfully deployed

1 active deployment
preview — e59cf279 Deployed Nov 20, 2026 by Sorte1 via deploy #1355
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant