Repository navigation
fix: wrap a block rotator only when its loop and leading initialisers are closed - #466
Merged
Merged
Conversation
… are closed block_rotator now requires closed_loop on the rotator, as called_plan and checksum_plan do, and refuses leading declarations whose initialisers hold await, yield, super, return or labelled jumps. A return, a loop var or function read after the block, a jump to an outer label, await/yield or super no longer change meaning when the block is moved into a function.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes F1 from the round 6 review of #461 (review/r6-ox2d2.md).
block_rotatormoved a block that ends in a rotator loop into(function () { ... })()without checking the loop. Areturn, a loopvaror function read after the block,continue L/break Lto an outer label,await/yieldorsuperthen changed meaning or broke the output, in both lanes. It now requiresclosed_loopon the loop, likecalled_planandchecksum_plan, and runs the same escape and lexical-use scan over the initialisers of the leading declarations.New rows in obfuscator_sweep_rows.rs: 14 escaping shapes print like node in both lanes and are not wrapped, and a closed block rotator is still wrapped.
Gates: