fix(deps): force patched kotlin-stdlib and koin-core versions - #4
Merged
Merged
Conversation
Aikido flagged kotlin-stdlib 1.8.21 (AIKIDO-2026-188556, AIKIDO-2026-550292, medium) and koin-core 3.5.6 (AIKIDO-2025-10040, low), both pulled in transitively via analyticssdk. Forces resolution to the patched versions as an immediate mitigation; the koin-core root cause is being fixed upstream in appanalytics-android-sdk#14. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR addresses security findings by forcing patched versions of transitive Android dependencies pulled in via com.siteimprove:analyticssdk:1.1.0, using Gradle’s dependency resolution strategy in the app module.
Changes:
- Adds a Gradle
resolutionStrategy.forceto pinkotlin-stdlibandkoin-coreto specific versions. - Documents the motivation (Aikido findings) inline in
android/app/build.gradle.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…onfigureEach - Bump kotlinVersion (Kotlin Gradle plugin) to 2.4.20 to match the forced kotlin-stdlib version; a plugin/stdlib mismatch causes build-time ABI/metadata errors. - Force kotlin-stdlib off rootProject.ext.kotlinVersion instead of a hardcoded literal so the two can't drift apart again. - Switch configurations.all to configurations.configureEach to keep Gradle's configuration-avoidance benefits. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Suppressed comments (1)
android/app/build.gradle:127
- This comment says the stdlib force can’t drift out of lockstep with the Kotlin Gradle plugin version, but in this repo the Kotlin plugin version isn’t explicitly pinned from
rootProject.ext.kotlinVersion(it’s currently only used for the stdlib force). Update the comment to avoid implying the plugin version is automatically aligned.
// kotlin-stdlib is forced to rootProject.ext.kotlinVersion, not a hardcoded literal,
// so it can never drift out of lockstep with the Kotlin Gradle plugin version.
bbsnly
added a commit
that referenced
this pull request
Aug 10, 2026
Picks up the koin-core CVE fix (Siteimprove/appanalytics-android-sdk#14) once that SDK version is published. Once merged, the kotlin-stdlib/ koin-core resolutionStrategy.force added in #4 can likely be re-evaluated/dropped. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Aikido flagged two transitive dependencies in
android/app/build.gradle, both pulled in viacom.siteimprove:analyticssdk:1.1.0:kotlin-stdlib1.8.21 (AIKIDO-2026-188556, AIKIDO-2026-550292 — medium)koin-core3.5.6 (AIKIDO-2025-10040 — low)Neither version is pinned directly in this repo or in analyticssdk's own kotlin plugin version (2.0.20), so they're resolved from somewhere further down the dependency graph.
Change
Adds a
resolutionStrategy.forceinandroid/app/build.gradlepinning both to their patched versions (kotlin-stdlib2.4.20,koin-core4.0.2), regardless of which transitive dependency requests the old ones.Caveat — please verify before merge
I could not run a live Gradle build to confirm this resolves cleanly (local JDK is 25; Gradle 8.10.2 doesn't support it, and I didn't want to change the machine's JDK to test). Please run
./gradlew :app:dependencies(or a full build) locally/in CI before merging to confirm the forced versions don't conflict with anything else in the graph.Related
koin-bomto 4.0.2). Once that's published and this repo's analyticssdk dependency is bumped to pick it up, the koin-core force here can likely be dropped.🤖 Generated with Claude Code