chore(deps): bump analyticssdk to 1.3.1 - #5
Merged
Merged
Conversation
Picks up the koin-core CVE fix (Siteimprove/appanalytics-android-sdk#14) once that SDK version is published. Once merged, the kotlin-stdlib/ koin-core resolutionStrategy.force added in #4 can likely be re-evaluated/dropped. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the Android app module’s dependency on com.siteimprove:analyticssdk to a newer version intended to pick up upstream fixes (notably around the transitive dependency mitigation discussed in #4).
Changes:
- Bump
com.siteimprove:analyticssdkfrom1.1.0to1.3.1inandroid/app/build.gradle.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Follow-up to #4's mitigation. #4 forces a patched
koin-coreversion locally as a stopgap; this bumps the actualanalyticssdkdependency to pick up the real fix from the SDK repo.Change
Bumps
com.siteimprove:analyticssdkfrom 1.1.0 to 1.3.1 inandroid/app/build.gradle.Once this merges
Re-evaluate whether the
resolutionStrategy.forceforkotlin-stdlib/koin-coreadded in #4 is still needed, or can be narrowed/dropped now that the dependency itself is patched.🤖 Generated with Claude Code