Repository navigation
Add manual Prepublish integration tests - #65
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepublish needs repeatable coverage for the draft-content and styling concerns raised in #64. This adds manual browser and WordPress integration tests, with readable Given/When/Then steps and failure screenshots.
Both new workflows use only
workflow_dispatch. The optionalplugin_refinput selects the plugin version independently of the test code; userefs/pull/64/headto test that fix. A blank input tests the workflow commit’s plugin, so the regression cases are expected to fail against current master until #64 is merged. The workflows record the resolved plugin commit and require no Siteimprove secrets.Validation: 30 browser tests and 18 WordPress tests passed locally against #64 (
a23af8519861f674d700cbe4fe183817f47458dc). The fresh-checkout run exposed a login-autofocus race; the tests now wait for WordPress’s initial focus before typing. Readiness and split-origin revision capture were revalidated in both browsers after that adjustment. Failure screenshot/report attachment was verified with temporary intentional failures in both browsers. The SDK is simulated; authenticated Siteimprove scans and report rerenders remain pending account access. Editor UI, additional WordPress/PHP versions, subdirectory installs and multisite are future coverage.Production plugin files and existing release/deployment workflows are unchanged. The commit includes
[skip ci]to avoid starting existing push/PR workflows during review. No GitHub workflow has been dispatched.