Repository navigation
Add manual live Prepublish smoke test - #66
Merged
Merged
Conversation
MortenFriisSiteImprove
changed the base branch from
test/prepublish-workflows
to
master
September 10, 2026 19:11
MortenFriisSiteImprove
marked this pull request as ready for review
September 10, 2026 19:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The credential-free tests in #65 verify WordPress preview capture but cannot establish that Siteimprove accepts the draft or returns results. This follow-up adds an initial manual Chromium test that signs in with a direct test account, verifies existing Live page data for the mapped crawled URL, and requests a fresh Prepublish check of an unpublished autosave with an empty HTML title.
The test observes the real SDK handoff and requires this run's unique draft marker before accepting a completed missing-title result. A disposable WordPress fixture preserves the mapped path and query; the plugin performs its normal Public URL conversion. The crawled website is never visited directly.
The workflow is manual-only, restricted to master, pinned to PR #64 commit a23af85, and uses the siteimprove-test environment. The six environment secrets are passed only to the live step. Account diagnostics, screenshots, traces and server logs are not uploaded. No workflow has been dispatched.
Validation: ten credential-free contract tests passed, including both login failure paths and account-artifact privacy guards. Four WordPress fixture checks passed in Chromium and Firefox, covering root/nested paths, query preservation, empty titles, draft privacy and inline styles. The synthetic cross-origin observer check passed in Chromium. Its Firefox variant failed during iframe initialization; observer coverage is scoped to Chromium, matching the live runner.
This remains a draft: actual account login, entitlement, SDK selectors, the missing-title issue label and use of the unrelated crawled site's context have not been validated against Siteimprove. Report-rerender styling remains a manual acceptance check. The first authorized live run may require adjustments to those integration details.
Targets master after #65 merged. This diff contains only the live-test follow-up; production plugin code is unchanged. Review this follow-up before enabling a manual live run.