Repository navigation
fix(web): keep item page hero text readable over bright artwork #4944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -41,10 +41,13 @@ | |
| min-height: 0; | ||
| } | ||
|
|
||
| /* The copy hugs its text from the bottom of the hero instead of filling its | ||
| height, so the scrim it draws behind itself (app.css) starts at the text. */ | ||
| .item-detail-hero[data-viewport-bounded="true"] .detail-hero-copy { | ||
| display: flex; | ||
| flex-direction: column; | ||
| height: 100%; | ||
| max-height: 100%; | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. G1 (medium): Changing On episode pages (
(On desktop Suggested fix: Resolve the action-bar cap against the
|
||
| margin-top: auto; | ||
|
Quick104 marked this conversation as resolved.
Resolved
|
||
| min-height: 0; | ||
| width: 100%; | ||
| } | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: the mask is symmetric. It has the same 8rem fade, with the same stops, at both ends, so flipping its angle in RTL produces the same mask.
calc(90deg * var(--dir-sign))changes nothing here, and the PR description's "mirrored by --dir-sign" makes it look like something depends on reading direction. RTL support comes from theinset-inlineoffsets. A plain90deg(orto right) gives the same result in both directions. Use--dir-signonly if the two ends ever get different fades.